You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/03/14 03:09:32 UTC

[GitHub] [incubator-celeborn] FMX opened a new pull request, #1343: [CELEBORN-419][FLINK] Fix memory leak when receive RPCs with body.

FMX opened a new pull request, #1343:
URL: https://github.com/apache/incubator-celeborn/pull/1343

   ### What changes were proposed in this pull request?
   Message setBody method should not be wrapped buffer again which will cause a memory leak.
   
   
   ### Why are the changes needed?
   Ditto.
   
   
   ### Does this PR introduce _any_ user-facing change?
   NO.
   
   
   ### How was this patch tested?
   UT and cluster run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1343: [CELEBORN-419][FLINK] Fix memory leak when receive RPCs with body.

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1343:
URL: https://github.com/apache/incubator-celeborn/pull/1343#issuecomment-1467291926

   ## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1343](https://codecov.io/gh/apache/incubator-celeborn/pull/1343?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3c7540) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/3600ccc4e3f20aa5c12636852c93925d2f3459c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3600ccc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1343      +/-   ##
   ============================================
   + Coverage     27.81%   27.82%   +0.01%     
   - Complexity      846      847       +1     
   ============================================
     Files           221      221              
     Lines         18498    18496       -2     
     Branches       1981     1981              
   ============================================
     Hits           5144     5144              
   + Misses        13003    13001       -2     
     Partials        351      351              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/celeborn/common/network/protocol/Message.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9wcm90b2NvbC9NZXNzYWdlLmphdmE=) | `48.46% <ø> (+0.98%)` | :arrow_up: |
   
   ... and [2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1343/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] FMX merged pull request #1343: [CELEBORN-419][FLINK] Fix memory leak when receive RPCs with body.

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1343:
URL: https://github.com/apache/incubator-celeborn/pull/1343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org