You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Duo Zhang (JIRA)" <ji...@apache.org> on 2019/02/21 11:02:00 UTC

[jira] [Commented] (HBASE-21943) The usage of RegionLocations.mergeRegionLocations is wrong for async client

    [ https://issues.apache.org/jira/browse/HBASE-21943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773966#comment-16773966 ] 

Duo Zhang commented on HBASE-21943:
-----------------------------------

Ping [~stack]. This also effects branch-2.0. Will prepare a patch soon...

> The usage of RegionLocations.mergeRegionLocations is wrong for async client
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-21943
>                 URL: https://issues.apache.org/jira/browse/HBASE-21943
>             Project: HBase
>          Issue Type: Bug
>          Components: asyncclient, Client
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 2.2.0, 2.0.5, 2.3.0, 2.1.4
>
>
> In AsyncRegionLocatorHelper.mergeRegionLocations we create a new RegionLocations and call mergeRegionLocations on it, expected that it will be changed by this method, but actually the method will not modify the object itself, it will return a new one...
> And we are lucky that we create the RegionLocations with the new locations, so usually we will get update result. But when testing HBASE-21717, we meet another bug in AsyncNonMetaRegionLocator.isEqual, where we missed a '!' when checking server name equals...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)