You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/19 03:24:22 UTC

[GitHub] [apisix] fukiki commented on a change in pull request #2451: Plugin(request-validation): use draft7 way to rewrite the JSON Schema

fukiki commented on a change in pull request #2451:
URL: https://github.com/apache/apisix/pull/2451#discussion_r507405839



##########
File path: t/plugin/request-validation.t
##########
@@ -271,46 +231,6 @@ hello1 world
                             "type": "roundrobin"
                         },
                         "uri": "/opentracing"
-                }]],

Review comment:
       > @fukiki may I ask the reason to to remove these contents? Thanks.
   
   In my test environment, the parameter string is larger than the remain space of the fixed buffer, which causes nginx to report an error. Therefore, the optional parameter was deleted.
   The code in `t/plugin/request-validation.t` has been restored.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org