You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "seekskyworld (via GitHub)" <gi...@apache.org> on 2026/09/06 18:54:51 UTC
[PR] refactor(core): share canonical JSON serializer with eval and storage [maka]
seekskyworld opened a new pull request, #4932:
URL: https://github.com/apache/maka/pull/4932
Fixes #4927
## Summary
- expose the existing strict canonical JSON serializer through `@maka/core/canonical-json`
- replace the eval experiment and session-bundle manifest serializer copies
- preserve eval's trailing newline and collision behavior
- map manifest serializer failures back to `SessionBundleFileError('invalid_manifest', ...)`
## Motivation
Eval identities and portable bundle bytes were produced by separate serializers. Sharing the strict core authority keeps key ordering and rejection of unsupported JSON values consistent across both persistence boundaries.
## Validation
- npm --workspace @maka/core run build
- npm --workspace @maka/runtime run build
- npm --workspace @maka/runtime-host run build
- npm --workspace @maka/eval run build
- npm --workspace @maka/storage run build
- node --test packages/core/dist/__tests__/canonical-json.test.js packages/core/dist/__tests__/tool-args-identity.test.js packages/eval/dist/__tests__/experiment-directory.test.js packages/storage/dist/__tests__/session-bundle-manifest.test.js (16/16)
- npx biome check on changed sources and tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] refactor(core): share canonical JSON serializer with eval and storage [maka]
Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #4932:
URL: https://github.com/apache/maka/pull/4932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org