You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ravi Phulari (JIRA)" <ji...@apache.org> on 2010/04/29 21:57:56 UTC
[jira] Created: (HADOOP-6735) Remove falut injection compilation
from default ant compilation and ant test-core.
Remove falut injection compilation from default ant compilation and ant test-core.
----------------------------------------------------------------------------------
Key: HADOOP-6735
URL: https://issues.apache.org/jira/browse/HADOOP-6735
Project: Hadoop Common
Issue Type: Improvement
Reporter: Ravi Phulari
Compiling fault-injection code while running ant tests increases test time by considerable amount of time. It would be great if by default fi code is not compiled every time ant tests are run.
We should add flag to run fault injection code on demand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-6735) Remove fault injection compilation
from default ant compilation and ant test-core.
Posted by "Ravi Phulari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Phulari resolved HADOOP-6735.
----------------------------------
Resolution: Not A Problem
Apparently there is ant run-test-core/hdfs/mapred and ant run-test-unit options to achieve this,
{noformat}
<target name="test-core" description="Run hdfs unit tests">
<delete file="${test.build.dir}/testsfailed"/>
<property name="continueOnFailure" value="true"/>
<antcall target="run-test-hdfs"/>
<antcall target="run-test-unit"/>
<antcall target="run-test-hdfs-fault-inject"/>
<available file="${test.build.dir}/testsfailed" property="testsfailed"/>
<fail if="testsfailed">Tests failed!</fail>
</target>
{noformat}
> Remove fault injection compilation from default ant compilation and ant test-core.
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-6735
> URL: https://issues.apache.org/jira/browse/HADOOP-6735
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ravi Phulari
>
> Compiling fault-injection code while running ant tests increases test time by considerable amount of time. It would be great if by default fi code is not compiled every time ant tests are run.
> We should add flag to run fault injection code on demand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6735) Remove fault injection compilation
from default ant compilation and ant test-core.
Posted by "Ravi Phulari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Phulari updated HADOOP-6735:
---------------------------------
Summary: Remove fault injection compilation from default ant compilation and ant test-core. (was: Remove falut injection compilation from default ant compilation and ant test-core.)
> Remove fault injection compilation from default ant compilation and ant test-core.
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-6735
> URL: https://issues.apache.org/jira/browse/HADOOP-6735
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ravi Phulari
>
> Compiling fault-injection code while running ant tests increases test time by considerable amount of time. It would be great if by default fi code is not compiled every time ant tests are run.
> We should add flag to run fault injection code on demand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6735) Remove fault injection compilation
from default ant compilation and ant test-core.
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862381#action_12862381 ]
Konstantin Boudnik commented on HADOOP-6735:
--------------------------------------------
Fault injection tests are valuable part of the hadoop testing. E.g. it allowed to find many problems in HDFS' append feature. Yes, the compilation time is slightly increases but compare to the runtime of all the tests it barely adds a percent or less.
Having an optional flag to switch some testing on/off is almost a guarantee that this testing will never be run by anyone.
Besides, FI tests are only part of 'test-core' target. You can avoid running it by starting 'ant run-test-core' instead of 'ant test'
> Remove fault injection compilation from default ant compilation and ant test-core.
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-6735
> URL: https://issues.apache.org/jira/browse/HADOOP-6735
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ravi Phulari
>
> Compiling fault-injection code while running ant tests increases test time by considerable amount of time. It would be great if by default fi code is not compiled every time ant tests are run.
> We should add flag to run fault injection code on demand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.