[GitHub] [accumulo] ivakegg commented on a diff in pull request #2665: Eventually Consistent scans / ScanServer feature

[GitBox <gi...@apache.org>]

ivakegg commented on code in PR #2665:
URL: https://github.com/apache/accumulo/pull/2665#discussion_r861803116


##########
core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java:
##########
@@ -44,6 +44,17 @@
  */
 public interface ScannerBase extends Iterable<Entry<Key,Value>>, AutoCloseable {
 
+  /**
+   * Consistency level for the scanner. The default level is IMMEDIATE, which means that this

Review Comment:
      * Consistency level for the scanner. The default level is IMMEDIATE, which means that this
      * scanner will see ALL keys and values that have been successfully written to a TabletServer.
      * EVENTUAL means that the scanner may not see the latest data that was written to a TabletServer,
      * but may instead see an older version of data.  Data that has not yet been minor compacted will
      * not be seen.



##########
core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/impl/BlockCacheConfiguration.java:
##########
@@ -41,13 +42,16 @@ public class BlockCacheConfiguration implements Configuration {
 
   private final long summaryMaxSize;
 
-  public BlockCacheConfiguration(AccumuloConfiguration conf) {
-    genProps = conf.getAllPropertiesWithPrefix(Property.TSERV_PREFIX);
+  public BlockCacheConfiguration(AccumuloConfiguration conf, Property serverPrefix,

Review Comment:
   Just an idea, but the code could be a little less susceptible  to coding error if we pass in a single flag for TSERVER vs SSERVER.  The properties used for each could be encoded in this class.  This is just a thought and does not require change unless you agree with my argument.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org