[jira] Commented: (JCR-1124) Core NodeTypeImpl requires equals() implementation

["David Rauschenbach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552345 ] 

David Rauschenbach commented on JCR-1124:
-----------------------------------------

My use case is that I have written an SPI, and I use JCR2SPI and SPI2JCR in unit tests , to see if things are passing through the SPI. 

What seems wrong to me is that I can't use equals to compare two javax.jcr.nodetype.NodeType's, even though they are equivalent, and especially just because one is from core, and the other is from JCR2SPI. So, I had to write a utility class to compare all the jcr NodeType attributes, to determine equality. It seems to me this code belongs in equals(), and not in my utility class. Just my 2 cents.

> Core NodeTypeImpl requires equals() implementation
> --------------------------------------------------
>
>                 Key: JCR-1124
>                 URL: https://issues.apache.org/jira/browse/JCR-1124
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.4
>            Reporter: David Rauschenbach
>            Priority: Minor
>
> The Jackrabbit core NodeTypeImpl class requires an equals method, that can successfully test for equality against any implementation javax.jcr.nodetype.NodeType.
> The current hack is to perform string comparison on NodeType.getName().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.