You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/23 02:19:08 UTC

[GitHub] [tvm] tmoreau89 commented on a change in pull request #7331: Update uTVM code to work with the nRF5340DK dev board.

tmoreau89 commented on a change in pull request #7331:
URL: https://github.com/apache/tvm/pull/7331#discussion_r563003136



##########
File path: python/tvm/target/target.py
##########
@@ -234,7 +234,10 @@ def micro(model="unknown", options=None):
     trans_table = {
         "host": [],
         "stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
+        "nrf5340dk": ["-keys=arm_cpu", "-mcpu=cortex-m33"],

Review comment:
       Nit: I'm curious as to why the STM has a `-march=...` field while the NRF has a `keys=...` target field. Could we keep it overall consistent? Thoughts on this @areusch 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org