[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4657: [CodeGen] Generate blob use LLVM directly

[GitBox <gi...@apache.org>]

zhiics commented on a change in pull request #4657: [CodeGen] Generate blob use LLVM directly
URL: https://github.com/apache/incubator-tvm/pull/4657#discussion_r364363748
 
 

 ##########
 File path: python/tvm/module.py
 ##########
 @@ -140,10 +140,16 @@ def export_library(self,
                              module.get_function("__tvm_is_system_module")())
 
         if self.imported_modules:
-            path_cc = temp.relpath("devc.cc")
-            with open(path_cc, "w") as f:
-                f.write(_PackImportsToC(self, is_system_lib))
-            files.append(path_cc)
+            if enabled("llvm"):
+                path_obj = temp.relpath("devc.o")
+                m = _PackImportsToLLVM(self, is_system_lib, str(_target.get_llvm_target_host()))
 
 Review comment:
   See my above comment as this is the only place we may need the getter

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services