You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/01/25 19:09:02 UTC
[GitHub] rhtyd commented on a change in pull request #3112: network:
Offerings do not have to have Security Grouping enabled
rhtyd commented on a change in pull request #3112: network: Offerings do not have to have Security Grouping enabled
URL: https://github.com/apache/cloudstack/pull/3112#discussion_r251101890
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -2246,9 +2246,6 @@ public Network createGuestNetwork(final long networkOfferingId, final String nam
if (_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), Service.SourceNat)) {
throw new InvalidParameterValueException("Service SourceNat is not allowed in security group enabled zone");
}
- if (!_networkModel.areServicesSupportedByNetworkOffering(ntwkOff.getId(), Service.SecurityGroup)) {
Review comment:
lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services