You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/07/17 22:05:54 UTC
Re: Review Request 60234: Linted support/push-commits.py.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60234/#review180723
-----------------------------------------------------------
Ship it!
I'm a committer, but I have not used this script before :)
Anyway, style looks better than before.
support/push-commits.py
Lines 37-49 (original), 54-66 (patched)
<https://reviews.apache.org/r/60234/#comment255940>
Hmmm... This logic seems easy to trick. (i.e. If a commit message contains multiple `Review: ...` lines.)
I'll open a separate issue to fix it: https://issues.apache.org/jira/browse/MESOS-7802
- Joseph Wu
On June 26, 2017, 8:49 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60234/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 8:49 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Joseph Wu.
>
>
> Bugs: MESOS-6390
> https://issues.apache.org/jira/browse/MESOS-6390
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This will allow us to use PyLint on the
> entire support directory in the future.
>
>
> Diffs
> -----
>
> support/push-commits.py 4835d67393aaf3a38a1da90ccc7c89a952bf9270
>
>
> Diff: https://reviews.apache.org/r/60234/diff/2/
>
>
> Testing
> -------
>
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
>
>
> Thanks,
>
> Armand Grillet
>
>