You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/07 15:07:41 UTC
[GitHub] [pulsar] aloyszhang opened a new pull request #11248: [hotfix] simplify code
aloyszhang opened a new pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248
### Motivation
Simplify code of `ManagedLedger.getManagedLedgerInfo()`
### Modifications
unify the method of generating `ManagedLedgerInfo`
### Verifying this change
This change is a code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: （no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #11248: [hotfix] simplify code
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248#issuecomment-878490418
@Renkai PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #11248: [hotfix] simplify code
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248#issuecomment-875739726
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #11248: [hotfix] simplify code
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #11248: [hotfix] simplify code
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248#issuecomment-879616335
@BewareMyPower PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #11248: [hotfix] simplify code
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248#issuecomment-876045103
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #11248: [hotfix] simplify code
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248#issuecomment-878490418
@Renkai PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang removed a comment on pull request #11248: [hotfix] simplify code
Posted by GitBox <gi...@apache.org>.
aloyszhang removed a comment on pull request #11248:
URL: https://github.com/apache/pulsar/pull/11248#issuecomment-875739726
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org