You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/26 12:45:13 UTC

[GitHub] [incubator-nuttx-apps] juniskane opened a new pull request #842: testing/smart: fix wrong hard-coded device pathname and sector size

juniskane opened a new pull request #842:
URL: https://github.com/apache/incubator-nuttx-apps/pull/842


   ## Summary
   SmartFS testing tool used hard-coded sector size, change to use default one.
   
   Also nowadays SmartFS initialization adds partition name to device node's name e.g. /dev/smart1SmartTest instead of /dev/smart1. 
   Pseudo root fs does not seem to like long names like /dev/smart1SmartTest (why?) so shorten to /dev/smart1test
   
   ## Impact
   Did not even compile without FS test also enabled due to wrong macro used, so this change is unlikely to make things worse :-)
   
   ## Testing
   Tested that this runs on device without crashing (asserting due to wrong sector size)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #842: testing/smart: fix wrong hard-coded device pathname and sector size

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #842:
URL: https://github.com/apache/incubator-nuttx-apps/pull/842#issuecomment-906886030


   @saramonteiro let's merge this PR first, your question can be addressed in the new patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #842: testing/smart: fix wrong hard-coded device pathname and sector size

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #842:
URL: https://github.com/apache/incubator-nuttx-apps/pull/842


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] saramonteiro commented on pull request #842: testing/smart: fix wrong hard-coded device pathname and sector size

Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #842:
URL: https://github.com/apache/incubator-nuttx-apps/pull/842#issuecomment-906476364


   Thanks for improving it.
   
   > Pseudo root fs does not seem to like long names like /dev/smart1SmartTest (why?)
   
   @juniskane, could you please adjust CONFIG_NAME_MAX and CONFIG_SMARTFS_MAXNAMLEN to a larger value and see if the issue persist?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org