You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/23 05:49:34 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3539: HDDS-6873. EC: Add block token support for ECReconstructionCoordinator
adoroszlai opened a new pull request, #3539:
URL: https://github.com/apache/ozone/pull/3539
## What changes were proposed in this pull request?
Support secure cluster by using block/container tokens in `ECReconstructionCoordinator`.
https://issues.apache.org/jira/browse/HDDS-6873
## How was this patch tested?
Changed existing integration test to require tokens.
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2544654342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #3539: HDDS-6873. EC: Add block token support for ECReconstructionCoordinator
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged PR #3539:
URL: https://github.com/apache/ozone/pull/3539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3539: HDDS-6873. EC: Add block token support for ECReconstructionCoordinator
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3539:
URL: https://github.com/apache/ozone/pull/3539#issuecomment-1164511425
> I just realized, SCMCommand actually defined with token. Do you think we can actually send the container token from SCM itself and use that? 1d is the default expiry time. Just a thought. But current approach also should fine. Even though we are creating containers from DN, ideally they are more responsible by SCM and blocks are responsible for DN. This can be separate JIRA also if that make sense to send the token over wire.
Thanks for the idea. Created HDDS-6939 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on pull request #3539: HDDS-6873. EC: Add block token support for ECReconstructionCoordinator
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on PR #3539:
URL: https://github.com/apache/ozone/pull/3539#issuecomment-1164425249
Changes looks good to me. I just realized, SCMCommand actually defined with token. Do you think we can actually send the container token from SCM itself and use that? 1d is the default expiry time. Just a thought. But current approach also should fine. Even though we are creating containers from DN, ideally they are more responsible by SCM and blocks are responsible for DN. This can be separate JIRA also if that make sense to send the token over wire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on pull request #3539: HDDS-6873. EC: Add block token support for ECReconstructionCoordinator
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on PR #3539:
URL: https://github.com/apache/ozone/pull/3539#issuecomment-1164722766
Thanks @adoroszlai for working on this in a short time.
And also thanks for filing the JIRA: https://issues.apache.org/jira/browse/HDDS-6939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3539: HDDS-6873. EC: Add block token support for ECReconstructionCoordinator
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3539:
URL: https://github.com/apache/ozone/pull/3539#issuecomment-1164531518
Thanks @umamaheswararao for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org