Re: [PR] feat: add observable commentary and collapsible work logs [maka]

["hqhq1025 (via GitHub)" <gi...@apache.org>]

hqhq1025 commented on PR #4270:
URL: https://github.com/apache/maka/pull/4270#issuecomment-5505641397

   Updated the branch to `9a234733d` and merged current `main` (`6b3f38ddf`).
   
   The implementation now follows the smaller architecture proposed in review and Discussion #4268:
   
   - progress and final output use ordinary assistant text across providers;
   - native Responses item/phase metadata remains adapter/replay-owned;
   - there is no shared assistant phase, synthetic `ProgressUpdate` tool, auxiliary provider request, split step budget, or Runtime Host/CLI wire change;
   - completed-turn final reply selection is derived from terminal Turn state and chronological trailing meaningful text;
   - rendering, Copy payload, and Copy availability share that selector;
   - provider-executed tool/text chronology is preserved through durable `contentOrder`.
   
   The previous CI failure was in Desktop E2E. The stable regression was the accessibility scenario still trying to reach a tool result through the retired flat layout. It now follows the real keyboard path through the collapsed outer work log and inner processing summary before opening the tool result. The second reported transcript-width failure passed after syncing current `main`.
   
   Validation on this revision:
   
   - `npm run typecheck`
   - `npm run lint`
   - `npm run format:check`
   - `npm run check:asf-headers`
   - `npm run astryx:surface-inventory`
   - `npm run check:renderer-architecture -- --base origin/main`
   - UI dist tests: 331/331
   - focused Runtime/Storage/Desktop tests: 267/267
   - original CI failure pair: 7/7
   - isolated sidebar suite and resize regression: 5/5
   - isolated streaming-remount regression: 1/1
   - isolated transcript-scroll regressions: 3/3
   - isolated WorkHub layout regression: 1/1
   
   A single long local Desktop E2E run passed 90 tests before an Electron teardown timeout caused cascading closed-page/fixture-start failures. Every earliest and representative failure from that cascade passed in isolation, including all tests related to this PR. Hosted CI has been retriggered by the push.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org