You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2017/01/11 21:41:27 UTC
Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/
-----------------------------------------------------------
Review request for Aurora and Santhosh Kumar Shanmugham.
Bugs: AURORA-1878
https://issues.apache.org/jira/browse/AURORA-1878
Repository: aurora
Description
-------
Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
Diffs
-----
src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
Diff: https://reviews.apache.org/r/55434/diff/
Testing
-------
Thanks,
Joshua Cohen
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Joshua Cohen <jc...@apache.org>.
> On Jan. 11, 2017, 10:05 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/common/status_checker.py, line 134
> > <https://reviews.apache.org/r/55434/diff/1/?file=1603106#file1603106line134>
> >
> > Just like Java, Python can do the formatting for you when needed. Just pass your arguments directly to the info function and the logger will do the rest if needed.
done, thanks for the nudge.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161310
-----------------------------------------------------------
On Jan. 11, 2017, 10:18 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 10:18 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1878
> https://issues.apache.org/jira/browse/AURORA-1878
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
> src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
>
> Diff: https://reviews.apache.org/r/55434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161310
-----------------------------------------------------------
Ship it!
I am aware this is just a move, but why not make it better along the way :)
src/main/python/apache/aurora/executor/common/status_checker.py (line 133)
<https://reviews.apache.org/r/55434/#comment232543>
Just like Java, Python can do the formatting for you when needed. Just pass your arguments directly to the info function and the logger will do the rest if needed.
- Stephan Erb
On Jan. 11, 2017, 10:41 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 10:41 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1878
> https://issues.apache.org/jira/browse/AURORA-1878
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
> src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
>
> Diff: https://reviews.apache.org/r/55434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161312
-----------------------------------------------------------
Master (a94601a) is red with this patch.
./build-support/jenkins/build.sh
Branch coverage is 0.715242221346987, but must be greater than 0.835
:analyzeReport FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 6' finished with non-zero exit value 137
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/scheduler/http/Maintenance
Test coverage missing for org/apache/aurora/scheduler/base/Jobs
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ModuleParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroIniParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter
Test coverage missing for org/apache/aurora/scheduler/storage/db/PruneVictim
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl
Test coverage missing for org/apache/aurora/scheduler/scheduling/RescheduleCalculator$RescheduleCalculatorImpl$1
Test coverage missing for org/apache/aurora/scheduler/offers/RandomJitterReturnDelay
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl$2
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter$PreemptionVictimFilterImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl$BackupConfig
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 32.691 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 11, 2017, 9:41 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 9:41 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1878
> https://issues.apache.org/jira/browse/AURORA-1878
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
> src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
>
> Diff: https://reviews.apache.org/r/55434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161303
-----------------------------------------------------------
Master (a94601a) is red with this patch.
./build-support/jenkins/build.sh
-----------
* What went wrong:
Execution failed for task ':analyzeReport'.
> Test coverage missing for org/apache/aurora/scheduler/storage/db/views/DbImage
Test coverage missing for org/apache/aurora/scheduler/http/Mname
Test coverage missing for org/apache/aurora/scheduler/http/Services
Test coverage missing for org/apache/aurora/scheduler/http/QuitCallback
Test coverage missing for org/apache/aurora/scheduler/http/Cron
Test coverage missing for org/apache/aurora/scheduler/app/VolumeParser
Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader$Schema
Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader
Test coverage missing for org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1
Test coverage missing for org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
Test coverage missing for org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroUtils
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2
Test coverage missing for org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$OpStats
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$1
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogEntry
Test coverage missing for org/apache/aurora/scheduler/log/mesos/MesosLog$LogStream$LogPosition
Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule
Test coverage missing for org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 29.828 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 11, 2017, 9:41 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 9:41 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1878
> https://issues.apache.org/jira/browse/AURORA-1878
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
> src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
>
> Diff: https://reviews.apache.org/r/55434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/
-----------------------------------------------------------
(Updated Jan. 11, 2017, 10:18 p.m.)
Review request for Aurora and Santhosh Kumar Shanmugham.
Changes
-------
Clean up logging.
Bugs: AURORA-1878
https://issues.apache.org/jira/browse/AURORA-1878
Repository: aurora
Description
-------
Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
Diff: https://reviews.apache.org/r/55434/diff/
Testing
-------
Thanks,
Joshua Cohen
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161305
-----------------------------------------------------------
@ReviewBot retry
- Joshua Cohen
On Jan. 11, 2017, 9:41 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 9:41 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1878
> https://issues.apache.org/jira/browse/AURORA-1878
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
> src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
>
> Diff: https://reviews.apache.org/r/55434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On Jan. 11, 2017, 2:11 p.m., Santhosh Kumar Shanmugham wrote:
> > Ship It!
Thanks for fixing this.
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161316
-----------------------------------------------------------
On Jan. 11, 2017, 1:41 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 1:41 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1878
> https://issues.apache.org/jira/browse/AURORA-1878
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
> src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
>
> Diff: https://reviews.apache.org/r/55434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 55434: Reduce logging by ChainedStatusChecker and
StatusManager when they're on the happy path.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161316
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Jan. 11, 2017, 1:41 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2017, 1:41 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1878
> https://issues.apache.org/jira/browse/AURORA-1878
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165
> src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0
>
> Diff: https://reviews.apache.org/r/55434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joshua Cohen
>
>