You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by qiuchenjian <gi...@git.apache.org> on 2019/01/09 03:28:13 UTC

[GitHub] carbondata pull request #3057: [CARBONDATA-3238] Solve StackOverflowError us...

GitHub user qiuchenjian opened a pull request:

    https://github.com/apache/carbondata/pull/3057

    [CARBONDATA-3238] Solve StackOverflowError using MV datamap

    【Problem】 An exception or error caused a run to abort. (Using MV)
    java.lang.StackOverflowError
    	at org.apache.spark.sql.catalyst.expressions.AttributeMap$$anonfun$get$1.apply(AttributeMap.scala:34)
    	at org.apache.spark.sql.catalyst.expressions.AttributeMap$$anonfun$get$1.apply(AttributeMap.scala:34)
    	at scala.Option.map(Option.scala:146)
    	at org.apache.spark.sql.catalyst.expressions.AttributeMap.get(AttributeMap.scala:34)
    	at org.apache.spark.sql.catalyst.expressions.AttributeMap.contains(AttributeMap.scala:36)
    	at org.apache.carbondata.mv.rewrite.SelectSelectGroupbyChildDelta$$anonfun$13.applyOrElse(DefaultMatchMaker.scala:693)
    
    【Cause】When column of table is lowcase and column of mv is uppercase and this column is the selected column(detail test case see the code), the tree node of this selected column  in the logic plan tree have will be alias which has a child of attributeReference, when this code run in the sel_3q.transformExpressions in DefaultMatchMaker.scala, the executor rule  will cause  loop call。
    
    【Solution】this executor rule only need be transformed once by one experssion, so define a flag to solve it
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qiuchenjian/carbondata MVStackException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3057
    
----
commit 3568ba53299b9f019ea41fc483bb5f79652c5352
Author: qiuchenjian <80...@...>
Date:   2019-01-09T03:07:41Z

    [CARBONDATA-3238] Solve StackOverflowError using MV datamap

----


---

[GitHub] carbondata issue #3057: [CARBONDATA-3238] Solve StackOverflowError using MV ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3057
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2228/



---

[GitHub] carbondata issue #3057: [CARBONDATA-3238] Solve StackOverflowError using MV ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3057
  
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10485/



---

[GitHub] carbondata issue #3057: [Test][CARBONDATA-3238] Solve StackOverflowError usi...

Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/3057
  
    retest please


---

[GitHub] carbondata issue #3057: [Test][CARBONDATA-3238] Solve StackOverflowError usi...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3057
  
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2448/



---

[GitHub] carbondata pull request #3057: [Test][CARBONDATA-3238] Solve StackOverflowEr...

Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian closed the pull request at:

    https://github.com/apache/carbondata/pull/3057


---

[GitHub] carbondata issue #3057: [Test][CARBONDATA-3238] Solve StackOverflowError usi...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3057
  
    Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10486/



---

[GitHub] carbondata issue #3057: [CARBONDATA-3238] Solve StackOverflowError using MV ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3057
  
    Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2447/



---

[GitHub] carbondata issue #3057: [Test][CARBONDATA-3238] Solve StackOverflowError usi...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/3057
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2229/



---

[GitHub] carbondata pull request #3057: [Test][CARBONDATA-3238] Solve StackOverflowEr...

Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian closed the pull request at:

    https://github.com/apache/carbondata/pull/3057


---

[GitHub] carbondata pull request #3057: [Test][CARBONDATA-3238] Solve StackOverflowEr...

Posted by qiuchenjian <gi...@git.apache.org>.
GitHub user qiuchenjian reopened a pull request:

    https://github.com/apache/carbondata/pull/3057

    [Test][CARBONDATA-3238] Solve StackOverflowError using MV datamap

    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qiuchenjian/carbondata MVStackException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/3057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3057
    
----
commit 3568ba53299b9f019ea41fc483bb5f79652c5352
Author: qiuchenjian <80...@...>
Date:   2019-01-09T03:07:41Z

    [CARBONDATA-3238] Solve StackOverflowError using MV datamap

commit 42cf1c70b7b14f8e79801fb3579e84ada5671735
Author: qiuchenjian <80...@...>
Date:   2019-01-09T06:17:33Z

    [CARBONDATA-3238] Solve StackOverflowError using MV datamap

----


---