[jira] [Resolved] (ZOOKEEPER-1978) Fix Multithreaded correctness Warnings

["Patrick Hunt (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt resolved ZOOKEEPER-1978.
-------------------------------------

    Resolution: Duplicate

Marking as dup - ZOOKEEPER-1982 addressed this issue.

> Fix Multithreaded correctness Warnings
> --------------------------------------
>
>                 Key: ZOOKEEPER-1978
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1978
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1978.patch
>
>
> findbugs is complaining
> {code}
>  if (sessionsById.get(id) == null) {
>              SessionImpl s = new SessionImpl(id, sessionTimeout);
>              sessionsById.put(id, s);
> }
> {code}
> is not atomic for the gap between get() and put().
> I suggest using putIfAbsent() instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)