You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2017/08/04 08:23:00 UTC
[jira] [Commented] (SLING-7027) Progress ETA seems to be calculated
incorrectly and not to be updated on update.
[ https://issues.apache.org/jira/browse/SLING-7027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114104#comment-16114104 ]
Carsten Ziegeler commented on SLING-7027:
-----------------------------------------
Good catch [~karlpauls]
I think the calculation should rather be (if I'm not confusing things):
final long eta = System.currentTimeMillis() + (elapsed / current) * (steps - current);
elapsed is the time taken for the steps so far (current number of steps)
elapsed/current is the average for a single step
(steps-current) is the number of remaining steps
> Progress ETA seems to be calculated incorrectly and not to be updated on update.
> --------------------------------------------------------------------------------
>
> Key: SLING-7027
> URL: https://issues.apache.org/jira/browse/SLING-7027
> Project: Sling
> Issue Type: Bug
> Components: Event
> Affects Versions: Event 4.2.4
> Reporter: Karl Pauls
> Priority: Minor
> Fix For: Event 4.3.0
>
> Attachments: eta.patch
>
>
> It looks to me like the eta is not correctly calculated in JobImpl.setProgress and not set correctly in JobImp.update.
> I would like to apply the attached patch to fix it. Does that look correct to others?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)