You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Ankit Jain (JIRA)" <ji...@apache.org> on 2012/05/09 11:56:06 UTC
[jira] [Created] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Ankit Jain created OFBIZ-4866:
---------------------------------
Summary: Split Into Multiple Shipment Button is not working
Key: OFBIZ-4866
URL: https://issues.apache.org/jira/browse/OFBIZ-4866
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Ankit Jain
Priority: Minor
Fix For: SVN trunk
Split Into Multiple Shipment Button is not working on quick checkout page
https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Ankit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279594#comment-13279594 ]
Ankit Jain commented on OFBIZ-4866:
-----------------------------------
Thanks Jacques :)
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
> Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272143#comment-13272143 ]
Jacques Le Roux commented on OFBIZ-4866:
----------------------------------------
Thanks Ankit,
It was late and stupidely I only added one item, so the button did not show ;)
About my other point, I think we should really avoid do "duplicate" ecommerce code in order manager. Could we not rather refactor the code and include only one version in order manager then used also from ecommerce? Because dependency from order manager is correct but other way is bad. I know you did not "reuse" the code but duplicated it rather.
To summarize:
* Duplicate/adapt ecommerce in order manager => bad
* Make a dependency from order manager to ecommerce => bad
* Make a dependency from ecommerce to order manager => best practise
I might have missed something (just browsed the patch), then please explain.
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Ankit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ankit Jain updated OFBIZ-4866:
------------------------------
Attachment: OFBIZ-4866.patch
I have checked code and found that either its not implemented or code is removed.
I am not sure its a bug or an improvement, I took reference from front-end Split Ship functionality and implemented it for backend quick checkout.
Attaching patch for it.
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4866) Split Into Multiple Shipment Button is
not working
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4866.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 12.04
Release Branch 11.04
Assignee: Jacques Le Roux
Thanks Ankit,
Your patch is in
trunk r1340415
R12.04 r1340417
R11.04 r1340418
R10.04 r1340419
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk, Release Branch 12.04
>
> Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Ankit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ankit Jain updated OFBIZ-4866:
------------------------------
Attachment: Updated_OFBIZ-4866.patch
Jacques,
The ordermgr code is not dependend on ecommerce code and also not a duplicate, I have modified the code and used here in ordermgr.
Now we can reuse this code in ecommerce.
Attaching a updated patch.
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Ankit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272119#comment-13272119 ]
Ankit Jain commented on OFBIZ-4866:
-----------------------------------
Jacques,
In ecommerce this functionality is working, I did for ordermgr.
When you place and order from backend(Ordermgr) and chose Quick Finalize Order it redirect you to quickcheckout page (https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout) here on the left side there is a button "Split into multiple Shipment". When you click on this button it will show
org.ofbiz.webapp.control.RequestHandlerException: Unknown request [splitship]; this request does not exist or cannot be called directly.
I took the reference and also reused the code of ecommerce for this Split Shipment.
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Ankit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ankit Jain updated OFBIZ-4866:
------------------------------
Attachment: Updated_OFBIZ-4866.patch
Updated patch.
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Pierre Smits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271263#comment-13271263 ]
Pierre Smits commented on OFBIZ-4866:
-------------------------------------
Hi ankit Jain,
Can this also be applied to already released versions? If so, would you please be so kind to adjust the affected and fix versions?
Regards,
Pierre
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Ankit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ankit Jain updated OFBIZ-4866:
------------------------------
Fix Version/s: Release Branch 10.04
Affects Version/s: Release 10.04
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4866) Split Into Multiple Shipment Button
is not working
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271726#comment-13271726 ]
Jacques Le Roux commented on OFBIZ-4866:
----------------------------------------
Hi Ankit,
Could you please give more information where to find this "not working" thing on UI?
Also can't we reuse code from order manager in ecommerce at the end?
> Split Into Multiple Shipment Button is not working
> --------------------------------------------------
>
> Key: OFBIZ-4866
> URL: https://issues.apache.org/jira/browse/OFBIZ-4866
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: Release Branch 10.04, SVN trunk
>
> Attachments: OFBIZ-4866.patch, Updated_OFBIZ-4866.patch
>
>
> Split Into Multiple Shipment Button is not working on quick checkout page
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/quickcheckout
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira