You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Randy Abernethy (JIRA)" <ji...@apache.org> on 2014/04/02 21:24:14 UTC

[jira] [Created] (THRIFT-2443) Node fails cross lang tests

Randy Abernethy created THRIFT-2443:
---------------------------------------

             Summary: Node fails cross lang tests
                 Key: THRIFT-2443
                 URL: https://issues.apache.org/jira/browse/THRIFT-2443
             Project: Thrift
          Issue Type: Bug
          Components: Node.js - Library
    Affects Versions: 0.9.2
         Environment: tests
            Reporter: Randy Abernethy
            Assignee: Randy Abernethy
            Priority: Minor
             Fix For: 0.9.2


The Node.js test_driver.js fails on cross platform tests due to mismatches in leaf elements of the testInsanity() method return value. Node supplying nulls and C++ supplying an empty map and empty list.

Taking the C++ form as the defacto correct wire implementation, this patch updates Node.js to expect/return empty objects rather than null.

This patch also adds the ability to test i64 values when within the limits of a JavaScript number.

Note that Node.js multiplex tests still fail per THRIFT-2405



--
This message was sent by Atlassian JIRA
(v6.2#6252)