You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dinesh Bhat (Code Review)" <ge...@cloudera.org> on 2016/11/08 22:48:28 UTC
[kudu-CR] [doc] 1.1.0 release notes for tools
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5012
to review the following change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
[doc] 1.1.0 release notes for tools
Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
---
M docs/release_notes.adoc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/5012/1
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5012/2/docs/release_notes.adoc
File docs/release_notes.adoc:
PS2, Line 59: failure
> Seems like the wrong word considering we're deleting data... maybe "failure
yeah, sounds better, done.
PS2, Line 60: server is unable t
> "is unable to restart"
Done
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
[doc] 1.1.0 release notes for tools
Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Reviewed-on: http://gerrit.cloudera.org:8080/5012
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/release_notes.adoc
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
Patch Set 1:
(2 comments)
I also added couple of more tools which got pushed few minutes ago.
http://gerrit.cloudera.org:8080/#/c/5012/1/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 153: === Command line tools
> Wrong section, this is known issues and limitations. You want to be all the
Done, added just after 'optimizations and improvements' section.
PS1, Line 155: is added
> That feels wrong. Reading through http://ell.stackexchange.com/questions/17
Done
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5012/1/docs/release_notes.adoc
File docs/release_notes.adoc:
Line 153: === Command line tools
Wrong section, this is known issues and limitations. You want to be all the way up.
PS1, Line 155: is added
That feels wrong. Reading through http://ell.stackexchange.com/questions/17132/difference-between-is-added-and-was-added I'd write "has been added" or "was added".
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5012
to look at the new patch set (#4).
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
[doc] 1.1.0 release notes for tools
Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
---
M docs/release_notes.adoc
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/5012/4
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5012/3/docs/release_notes.adoc
File docs/release_notes.adoc:
PS3, Line 57: tablet
> replica
Done
PS3, Line 59: delete the
: replica of a tablet
> "delete a replica"
Done
PS3, Line 60: when the tablet server is unable to restart due to bad state of the replica.
> Is this part really necessary? "kudu local_replica delete" can be used for
Yeah, I wanted to emphasize implicitly that this tool is mainly used when tablet server is offline for so and so reasons. Come to think of it, the fact that it's an action under 'local_replica' makes it obvious that this tool can be used only when the server is offline, isn't it ? Removed it now.
Also, this tool only works with --clean_unsafe flag for the deletion to happen. otherwise it throws 'currently unsupported' and that support for 'tombstoning the tablet when server is offline' will be part of upcoming release. Although all this has clear help description under the tool, should we put that in release notes as well ?
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5012/3/docs/release_notes.adoc
File docs/release_notes.adoc:
PS3, Line 57: tablet
replica
PS3, Line 59: delete the
: replica of a tablet
"delete a replica"
PS3, Line 60: when the tablet server is unable to restart due to bad state of the replica.
Is this part really necessary? "kudu local_replica delete" can be used for various reasons; why bother calling out one? Especially since you didn't call out any reasons for the other new tools.
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5012
to look at the new patch set (#2).
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
[doc] 1.1.0 release notes for tools
Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/5012/2
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5012
to look at the new patch set (#3).
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
[doc] 1.1.0 release notes for tools
Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
---
M docs/release_notes.adoc
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/5012/3
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5012/3/docs/release_notes.adoc
File docs/release_notes.adoc:
PS3, Line 60:
> Yeah, I wanted to emphasize implicitly that this tool is mainly used when t
Nah, I think the specifics of --clean_unsafe are detailed enough that they aren't needed.
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [doc] 1.1.0 release notes for tools
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [doc] 1.1.0 release notes for tools
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5012/2/docs/release_notes.adoc
File docs/release_notes.adoc:
PS2, Line 59: recovery
Seems like the wrong word considering we're deleting data... maybe "failure recovery" tool would be more accurate?
PS2, Line 60: was not able to run
"is unable to restart"
--
To view, visit http://gerrit.cloudera.org:8080/5012
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc80b356d4cec6d0065a515dce5fdd94581346a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes