You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gyfora <gi...@git.apache.org> on 2016/08/24 10:05:20 UTC
[GitHub] flink pull request #2413: [FLINK-4471] Use user code classloader to deserial...
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/2413
[FLINK-4471] Use user code classloader to deserialize state descriptor in Rocks backend
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
\u2026r in RocksDb backend
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gyfora/flink FLINK-4471
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2413.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2413
----
commit b046c768d9b2c79297ae37c5dac2aa66a94ebc37
Author: Gyula Fora <gy...@apache.org>
Date: 2016-08-24T10:02:51Z
[FLINK-4471] Use user code classloader to deserialize state descriptor in RocksDb backend
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2413: [FLINK-4471] Use user code classloader to deserialize sta...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the issue:
https://github.com/apache/flink/pull/2413
Done, we can close this I guess if you are fixing it in your PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2413: [FLINK-4471] Use user code classloader to deserialize sta...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2413
Yes, please. \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2413: [FLINK-4471] Use user code classloader to deserialize sta...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2413
It should be fixed by not loading the `StateDescriptor` anymore, yes. We should maybe only merge it on the 1.1.* release branch because for 1.2 it will be overwritten by our changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2413: [FLINK-4471] Use user code classloader to deserialize sta...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2413
@aljoscha Is this fixed in the "key group" rework? What about merging this for version 1.1.2 anyways?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2413: [FLINK-4471] Use user code classloader to deserialize sta...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the issue:
https://github.com/apache/flink/pull/2413
Should I push this on 1.1 then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2413: [FLINK-4471] Use user code classloader to deserial...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora closed the pull request at:
https://github.com/apache/flink/pull/2413
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2413: [FLINK-4471] Use user code classloader to deserialize sta...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2413
I think so, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---