You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/01/15 01:59:09 UTC

Review Request 29908: Need to provide meaningful names for the stage context in Kerb API call response

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29908/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-9136
    https://issues.apache.org/jira/browse/AMBARI-9136


Repository: ambari


Description
-------

In the API response for Kerberizing the cluster, stage_context is set to "Process Kerberos Operations" for all operations.  This needs to be more specific (e.g., Generate Principals, Generate Keytabs, Distribute Keytabs, etc).  

Due to the current behavior, "Kerberize Cluster" page repeatedly shows "Process Kerberos Operations" one after another and it doesn't make much sense to the end user.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java e91d538 

Diff: https://reviews.apache.org/r/29908/diff/


Testing
-------

Manually tested in test cluster.

No unit tests were altered since only cosmetic changes were made.


Thanks,

Robert Levas


Re: Review Request 29908: Need to provide meaningful names for the stage context in Kerb API call response

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29908/#review68182
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Jan. 15, 2015, 12:59 a.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29908/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2015, 12:59 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9136
>     https://issues.apache.org/jira/browse/AMBARI-9136
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the API response for Kerberizing the cluster, stage_context is set to "Process Kerberos Operations" for all operations.  This needs to be more specific (e.g., Generate Principals, Generate Keytabs, Distribute Keytabs, etc).  
> 
> Due to the current behavior, "Kerberize Cluster" page repeatedly shows "Process Kerberos Operations" one after another and it doesn't make much sense to the end user.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java e91d538 
> 
> Diff: https://reviews.apache.org/r/29908/diff/
> 
> 
> Testing
> -------
> 
> Manually tested in test cluster.
> 
> No unit tests were altered since only cosmetic changes were made.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>