You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ibessonov (via GitHub)" <gi...@apache.org> on 2023/04/03 09:00:25 UTC
[GitHub] [ignite-3] ibessonov opened a new pull request, #1885: IGNITE-19172 Obsolete TODO comments addressed and removed.
ibessonov opened a new pull request, #1885:
URL: https://github.com/apache/ignite-3/pull/1885
https://issues.apache.org/jira/browse/IGNITE-19172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #1885: IGNITE-19172 Obsolete TODO comments addressed and removed.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #1885:
URL: https://github.com/apache/ignite-3/pull/1885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1885: IGNITE-19172 Obsolete TODO comments addressed and removed.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #1885:
URL: https://github.com/apache/ignite-3/pull/1885#discussion_r1155860143
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/DataStorageManager.java:
##########
@@ -95,7 +95,6 @@ public void stop() throws Exception {
* UnknownDataStorageConfigurationSchema#UNKNOWN_DATA_STORAGE} and there is only one engine, then it will be the default, otherwise
* there will be no default.
*/
- // TODO: IGNITE-16835 Remove it.
Review Comment:
This method is still required, IGNITE-16835 is closed as `Won't Fix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1885: IGNITE-19172 Obsolete TODO comments addressed and removed.
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #1885:
URL: https://github.com/apache/ignite-3/pull/1885#discussion_r1155840816
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/DataStorageManager.java:
##########
@@ -95,7 +95,6 @@ public void stop() throws Exception {
* UnknownDataStorageConfigurationSchema#UNKNOWN_DATA_STORAGE} and there is only one engine, then it will be the default, otherwise
* there will be no default.
*/
- // TODO: IGNITE-16835 Remove it.
Review Comment:
Why didn't we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1885: IGNITE-19172 Obsolete TODO comments addressed and removed.
Posted by "sashapolo (via GitHub)" <gi...@apache.org>.
sashapolo commented on code in PR #1885:
URL: https://github.com/apache/ignite-3/pull/1885#discussion_r1155871926
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/DataStorageManager.java:
##########
@@ -95,7 +95,6 @@ public void stop() throws Exception {
* UnknownDataStorageConfigurationSchema#UNKNOWN_DATA_STORAGE} and there is only one engine, then it will be the default, otherwise
* there will be no default.
*/
- // TODO: IGNITE-16835 Remove it.
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org