You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (Created) (JIRA)" <ji...@apache.org> on 2011/10/18 19:23:10 UTC
[jira] [Created] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
-----------------------------------------------------------------
Key: SHINDIG-1643
URL: https://issues.apache.org/jira/browse/SHINDIG-1643
Project: Shindig
Issue Type: Bug
Reporter: Ryan Baxter
Fix For: 3.0.0
If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1643) Gadget Admin Code Does Not Take Into
Account Ports In Gadget URLs
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1643.
---------------------------------
part of 2.5.0-beta1 release.
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 2.5.0-beta1
>
> Attachments: issue-1643.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
Posted by "Ryan Baxter (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1643:
---------------------------------
Attachment: issue-1643.patch
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Attachments: issue-1643.patch
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129920#comment-13129920 ]
jiraposter@reviews.apache.org commented on SHINDIG-1643:
--------------------------------------------------------
bq. On 2011-10-18 18:34:38, Dan Dumont wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java, line 185
bq. > <https://reviews.apache.org/r/2425/diff/2/?file=50897#file50897line185>
bq. >
bq. > else if, to avoid checks if the 1st one matched.
Otherwise, LGTM
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2425/#review2653
-----------------------------------------------------------
On 2011-10-18 18:13:24, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2425/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 18:13:24)
bq.
bq.
bq. Review request for shindig and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
bq.
bq.
bq. This addresses bug SHINDIG-1643.
bq. https://issues.apache.org/jira/browse/SHINDIG-1643
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758
bq.
bq. Diff: https://reviews.apache.org/r/2425/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests to test new functionality
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129901#comment-13129901 ]
jiraposter@reviews.apache.org commented on SHINDIG-1643:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2425/
-----------------------------------------------------------
(Updated 2011-10-18 18:13:24.355658)
Review request for shindig and Dan Dumont.
Changes
-------
Removed white spaces
Summary
-------
If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
This addresses bug SHINDIG-1643.
https://issues.apache.org/jira/browse/SHINDIG-1643
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758
Diff: https://reviews.apache.org/r/2425/diff
Testing
-------
Updated unit tests to test new functionality
Thanks,
Ryan
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129899#comment-13129899 ]
jiraposter@reviews.apache.org commented on SHINDIG-1643:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2425/
-----------------------------------------------------------
Review request for shindig and Dan Dumont.
Summary
-------
If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
This addresses bug SHINDIG-1643.
https://issues.apache.org/jira/browse/SHINDIG-1643
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758
Diff: https://reviews.apache.org/r/2425/diff
Testing
-------
Updated unit tests to test new functionality
Thanks,
Ryan
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130300#comment-13130300 ]
jiraposter@reviews.apache.org commented on SHINDIG-1643:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2425/
-----------------------------------------------------------
(Updated 2011-10-19 01:21:49.752578)
Review request for shindig and Dan Dumont.
Changes
-------
Updated based on Dans comments.
Summary
-------
If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
This addresses bug SHINDIG-1643.
https://issues.apache.org/jira/browse/SHINDIG-1643
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
Diff: https://reviews.apache.org/r/2425/diff
Testing
-------
Updated unit tests to test new functionality
Thanks,
Ryan
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1643) Gadget Admin Code Does Not Take
Into Account Ports In Gadget URLs
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129919#comment-13129919 ]
jiraposter@reviews.apache.org commented on SHINDIG-1643:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2425/#review2653
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java
<https://reviews.apache.org/r/2425/#comment5971>
else if, to avoid checks if the 1st one matched.
- Dan
On 2011-10-18 18:13:24, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2425/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-18 18:13:24)
bq.
bq.
bq. Review request for shindig and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
bq.
bq.
bq. This addresses bug SHINDIG-1643.
bq. https://issues.apache.org/jira/browse/SHINDIG-1643
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758
bq.
bq. Diff: https://reviews.apache.org/r/2425/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests to test new functionality
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs
> -----------------------------------------------------------------
>
> Key: SHINDIG-1643
> URL: https://issues.apache.org/jira/browse/SHINDIG-1643
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
> Fix For: 3.0.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira