Re: [PR] [WIP][SPARK-42309][SQL][FOLLOWUP] Raise exception directly instead of calling `resolveColumnsByPosition` [spark]

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #42762:
URL: https://github.com/apache/spark/pull/42762#discussion_r1349427325


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -110,10 +110,6 @@ object TableOutputResolver {
       resolveColumnsByPosition(tableName, query.output, actualExpectedCols, conf, errors += _)
     }
 
-    if (errors.nonEmpty) {

Review Comment:
   So, seem like we can delete `errors` parameter? (If can not find any test case to prove it worked)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org