[GitHub] [phoenix] apurtell commented on a change in pull request #1257: PHOENIX-6500 Allow 4.16 client to connect to 5.1 server

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #1257:
URL: https://github.com/apache/phoenix/pull/1257#discussion_r660960907



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java
##########
@@ -100,6 +101,11 @@
 
     public static final byte[] DATA_TABLE_NAME_PROP_BYTES = Bytes.toBytes(DATA_TABLE_NAME_PROP_NAME);
 
+    private static final Map<MajorMinorVersion, MajorMinorVersion> ALLOWED_SERVER_CLIENT_MAJOR_VERSION =
+            ImmutableMap.of(
+                    new MajorMinorVersion(5, 1), new MajorMinorVersion(4, 16)

Review comment:
       Per https://phoenix.apache.org/upgrading.html 
   
   > An older client (two minor versions back) will work with a newer server jar when the minor version is different, but not visa versa.
   > In other words, clients do not need to be upgraded in lock step with the server. 
       
   Does this mean you also need 
   
       new MajorMinorVersion(4, 15)
       new MajorMinorVersion(4, 14)
   
   ? This 4.16 client might run against a 4.14 server before upgrade, or a 4.15 server before upgrade? If supporting clients two minor versions back. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org