[GitHub] [spark] dongjoon-hyun commented on pull request #30264: [SPARK-33360][SQL] Simplify DS v2 write resolution

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on pull request #30264:
URL: https://github.com/apache/spark/pull/30264#issuecomment-722497907


   Could you fix the compilation error?
   ```
   [error] /home/jenkins/workspace/SparkPullRequestBuilder@2/sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala:103:14: class FakeV2WriteCommand needs to be abstract, since:
   [error] it has 2 unimplemented members.
   [error] /** As seen from class FakeV2WriteCommand, the missing signatures are as follows.
   [error]  *  For convenience, these are usable as stub implementations.
   [error]  */
   [error]   def isByName: Boolean = ???
   [error]   def withNewQuery(newQuery: org.apache.spark.sql.catalyst.plans.logical.LogicalPlan): org.apache.spark.sql.catalyst.plans.logical.V2WriteCommand = ???
   [error]   case class FakeV2WriteCommand(table: NamedRelation, query: LogicalPlan) extends V2WriteCommand
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org