You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "Barna Zsombor Klara (JIRA)" <ji...@apache.org> on 2016/07/13 14:25:20 UTC

[jira] [Created] (HIVE-14226) Invalid check on an ASTNode#toStringTree in CalcitePlanner

Barna Zsombor Klara created HIVE-14226:
------------------------------------------

             Summary: Invalid check on an ASTNode#toStringTree in CalcitePlanner
                 Key: HIVE-14226
                 URL: https://issues.apache.org/jira/browse/HIVE-14226
             Project: Hive
          Issue Type: Bug
            Reporter: Barna Zsombor Klara
            Priority: Minor


The patch for HIVE-12590 has modified the string tree representation of an ASTNode, so that everything except string literals are now lowercase.
However CalcitePlanner#genSelectLogicalPlan is still checking the occurrence of an uppercase TOK_FUNCTIONDI constant in the string tree.
(Line 2997 in CalcitePlanner on master)

I think this check will never evaluate to true, so we should either be using a lowercase String, or remove the check if it is unnecessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)