[GitHub] [samza] kw2542 commented on a change in pull request #1217: SAMZA-2381: Refactor JobRunner#run and split into multiple util methods.

[GitBox <gi...@apache.org>]

kw2542 commented on a change in pull request #1217: SAMZA-2381: Refactor JobRunner#run and split into multiple util methods.
URL: https://github.com/apache/samza/pull/1217#discussion_r346030155
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/util/CoordinatorStreamUtil.scala
 ##########
 @@ -37,13 +39,12 @@ object CoordinatorStreamUtil extends Logging {
     * Given a job's full config object, build a subset config which includes
     * only the job name, job id, and system config for the coordinator stream.
     */
-  def buildCoordinatorStreamConfig(config: Config) = {
+  def buildCoordinatorStreamConfig(config: Config): MapConfig = {
     val jobConfig = new JobConfig(config)
-    val buildConfigFactory = jobConfig.getCoordinatorStreamFactory();
+    val buildConfigFactory = jobConfig.getCoordinatorStreamFactory
 
 Review comment:
   reverted the change to keep consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services