You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2012/04/06 00:12:23 UTC
[jira] [Created] (SOLR-3328) executable bits of shellscripts in
solr source release
executable bits of shellscripts in solr source release
------------------------------------------------------
Key: SOLR-3328
URL: https://issues.apache.org/jira/browse/SOLR-3328
Project: Solr
Issue Type: Improvement
Components: Build
Reporter: Robert Muir
Fix For: 4.0
HossmanSays: in the solr src releases, some shell scripts are not executable by default.
I don't know if we can improve this? Maybe its an svn prop?
Maybe something needs to be specified to the tar/zip process?
Currently the 'source release' is really an svn export...
Personally i always do 'sh foo.sh' rather than './foo.sh',
but if it makes it more user-friendly we should figure it out
Just opening the issue since we don't forget about it, I think solr cloud
adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3328) executable bits of shellscripts in
solr source release
Posted by "Dawid Weiss (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248138#comment-13248138 ]
Dawid Weiss commented on SOLR-3328:
-----------------------------------
http://ant.apache.org/manual/Tasks/zip.html
bq. Starting with Ant 1.5.2, <zip> can store Unix permissions inside the archive (see description of the filemode and dirmode attributes for <zipfileset>). Unfortunately there is no portable way to store these permissions. Ant uses the algorithm used by Info-Zip's implementation of the zip and unzip commands - these are the default versions of zip and unzip for many Unix and Unix-like systems.
I remember we used to ZIP with unix permissions and they unzipped just fine (with permission sets).
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3328) executable bits of shellscripts in
solr source release
Posted by "Hoss Man (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247783#comment-13247783 ]
Hoss Man commented on SOLR-3328:
--------------------------------
bq. I don't believe that.
and to be clear:
* these *.sh files are executable if you "unzip" the solr.zip on a unix box
* these *.sh files are executable if you "tar -xzf" the solr.tgz on a unix box
* it is only if you "tar -xzf" the solr-src.txt thta these files are not executable
bq. I don't know if we can improve this? Maybe its an svn prop?
these files already have the svn:executable property set...
{noformat}
hossman@bester:~/lucene/3x_dev/solr/example/exampledocs$ svn propget svn:executable post.sh test_utf8.sh
post.sh - *
test_utf8.sh - *
{noformat}
...so it must either be something about how we do the export, or we are not telling the tar task to track the perms properly (i'm guessing the later)
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-3328) executable bits of
shellscripts in solr source release
Posted by "Uwe Schindler (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248561#comment-13248561 ]
Uwe Schindler edited comment on SOLR-3328 at 4/6/12 6:16 PM:
-------------------------------------------------------------
Yes, it also works for ZIP.
I checked Solr's build.xml: It already does what I propose (haveing several tarfilesets and zipfilesets). But it looks like it only sets mode to 755 for example/**.sh, not globally.
So the fix is to extend that to include *all* .sh files (just change some properties).
I checked both that TGZ and ZIP files for 3.x, too - they have (partly) incorrect attributes (binary tgz is correct, it has +x on example post.sh), so something is wrong with the src filesets (I think they are outdated as they dont respect the root). The files in scripts have no *.sh extension but are still shell scripts. Those have no 755, too.
I will look into this and provide patch fro trunk. 3.x is too late.
was (Author: thetaphi):
Yes, it also works for ZIP.
I checked Solr's build.xml: It already does what I propose (haveing several tarfilesets and zipfilesets). But it looks like it only sets mode to 755 for example/**.sh, not globally.
So the fix is to extend that to include *all* .sh files (just change some properties).
I checked both that TGZ and ZIP files for 3.x, too - they have incorrect attributes, so something is wrong with the filesets (I think they are outdated as they dont respect the root). The files in scripts have no *.sh extension but are still shell scripts. Those have no 755, too.
I will look into this and provide patch fro trunk. 3.x is too late.
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-3328) executable bits of
shellscripts in solr source release
Posted by "Uwe Schindler (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247770#comment-13247770 ]
Uwe Schindler edited comment on SOLR-3328 at 4/5/12 10:22 PM:
--------------------------------------------------------------
The ZIP task cannot handle this (as ZIP files dont know those +x attributes). But TAR task can handle this, by using <tarfileset/> instead of simple filesets. One could add <tarfileset includes="**/*.sh" filemode="755"/>.
See: http://ant.apache.org/manual/Types/tarfileset.html
was (Author: thetaphi):
The ZIP task cannot handle this (as ZIP files dont know those +x attributes). But TAR task can handle this, by using <tarfileset/> instead of simple filesets. One could add <tarfileset includes="**/*.sh" filemode="755"/>.
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3328) executable bits of shellscripts in
solr source release
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247773#comment-13247773 ]
Robert Muir commented on SOLR-3328:
-----------------------------------
{quote}
The ZIP task cannot handle this (as ZIP files dont know those +x attributes).
{quote}
I don't believe that.
I tried this on my computer:
touch foo.sh
touch bar.sh
chmod a+x bar.sh
zip test.zip foo.sh bar.sh
mkdir test
cd test
rmuir@beast:~/test$ unzip ../test.zip
Archive: ../test.zip
extracting: foo.sh
extracting: bar.sh
rmuir@beast:~/test$ ls -la
total 16
drwxrwxr-x 2 rmuir rmuir 4096 2012-04-05 18:26 .
drwxr-xr-x 87 rmuir rmuir 12288 2012-04-05 18:26 ..
-rw-rw-r-- 1 rmuir rmuir 0 2012-04-05 18:25 bar.sh
-rwxrwxr-x 1 rmuir rmuir 0 2012-04-05 18:25 foo.sh
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3328) executable bits of shellscripts in
solr source release
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248561#comment-13248561 ]
Uwe Schindler commented on SOLR-3328:
-------------------------------------
Yes, it also works for ZIP.
I checked Solr's build.xml: It already does what I propose (haveing several tarfilesets and zipfilesets). But it looks like it only sets mode to 755 for example/**.sh, not globally.
So the fix is to extend that to include *all* .sh files (just change some properties).
I checked both that TGZ and ZIP files for 3.x, too - they have incorrect attributes, so something is wrong with the filesets (I think they are outdated as they dont respect the root). The files in scripts have no *.sh extension but are still shell scripts. Those have no 755, too.
I will look into this and provide patch fro trunk. 3.x is too late.
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3328) executable bits of shellscripts in
solr source release
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247770#comment-13247770 ]
Uwe Schindler commented on SOLR-3328:
-------------------------------------
The ZIP task cannot handle this (as ZIP files dont know those +x attributes). But TAR task can handle this, by using <tarfileset/> instead of simple filesets. One could add <tarfileset includes="**/*.sh" filemode="755"/>.
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3328) executable bits of shellscripts in
solr source release
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247774#comment-13247774 ]
Robert Muir commented on SOLR-3328:
-----------------------------------
But still: this zip stuff is unrelated as we only release source packages in .tar.gz ....
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (SOLR-3328) executable bits of
shellscripts in solr source release
Posted by "Robert Muir (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247773#comment-13247773 ]
Robert Muir edited comment on SOLR-3328 at 4/5/12 10:27 PM:
------------------------------------------------------------
{quote}
The ZIP task cannot handle this (as ZIP files dont know those +x attributes).
{quote}
I don't believe that.
I tried this on my computer:
touch foo.sh
touch bar.sh
chmod a+x foo.sh
zip test.zip foo.sh bar.sh
mkdir test
cd test
rmuir@beast:~/test$ unzip ../test.zip
Archive: ../test.zip
extracting: foo.sh
extracting: bar.sh
rmuir@beast:~/test$ ls -la
total 16
drwxrwxr-x 2 rmuir rmuir 4096 2012-04-05 18:26 .
drwxr-xr-x 87 rmuir rmuir 12288 2012-04-05 18:26 ..
-rw-rw-r-- 1 rmuir rmuir 0 2012-04-05 18:25 bar.sh
-rwxrwxr-x 1 rmuir rmuir 0 2012-04-05 18:25 foo.sh
was (Author: rcmuir):
{quote}
The ZIP task cannot handle this (as ZIP files dont know those +x attributes).
{quote}
I don't believe that.
I tried this on my computer:
touch foo.sh
touch bar.sh
chmod a+x bar.sh
zip test.zip foo.sh bar.sh
mkdir test
cd test
rmuir@beast:~/test$ unzip ../test.zip
Archive: ../test.zip
extracting: foo.sh
extracting: bar.sh
rmuir@beast:~/test$ ls -la
total 16
drwxrwxr-x 2 rmuir rmuir 4096 2012-04-05 18:26 .
drwxr-xr-x 87 rmuir rmuir 12288 2012-04-05 18:26 ..
-rw-rw-r-- 1 rmuir rmuir 0 2012-04-05 18:25 bar.sh
-rwxrwxr-x 1 rmuir rmuir 0 2012-04-05 18:25 foo.sh
> executable bits of shellscripts in solr source release
> ------------------------------------------------------
>
> Key: SOLR-3328
> URL: https://issues.apache.org/jira/browse/SOLR-3328
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Reporter: Robert Muir
> Fix For: 4.0
>
>
> HossmanSays: in the solr src releases, some shell scripts are not executable by default.
> I don't know if we can improve this? Maybe its an svn prop?
> Maybe something needs to be specified to the tar/zip process?
> Currently the 'source release' is really an svn export...
> Personally i always do 'sh foo.sh' rather than './foo.sh',
> but if it makes it more user-friendly we should figure it out
> Just opening the issue since we don't forget about it, I think solr cloud
> adds some more shell scripts so we should at least figure out what we want to do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org