You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2018/07/02 21:35:28 UTC
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10851
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
IMPALA-6352: Dump backtrace on failure of TestTableSample
TestTableSample is a flaky test which has been failing very rarely due
to a possible hung thread. Therefore this patch adds a timeout to the
test and logs the backtrace of all impalads if timeout occurs, so we
can get more information on the state of those threads.
Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
---
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/query_test/test_tablesample.py
3 files changed, 45 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10851/1
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10851
to look at the new patch set (#2).
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
IMPALA-6352: Dump backtrace on failure of TestTableSample
TestTableSample is a flaky test which has been failing very rarely due
to a possible hung thread. Therefore this patch adds a timeout to the
test and logs the backtrace of all impalads if timeout occurs, so we
can get more information on the state of those threads.
Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
---
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/query_test/test_tablesample.py
3 files changed, 49 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/10851/2
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 23:26:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Jul 2018 02:48:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 23:19:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
IMPALA-6352: Dump backtrace on failure of TestTableSample
TestTableSample is a flaky test which has been failing very rarely due
to a possible hung thread. Therefore this patch adds a timeout to the
test and logs the backtrace of all impalads if timeout occurs, so we
can get more information on the state of those threads.
Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Reviewed-on: http://gerrit.cloudera.org:8080/10851
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/query_test/test_tablesample.py
3 files changed, 49 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
Patch Set 1:
(3 comments)
The approach seems good, just a few comments on naming
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/beeswax/impala_beeswax.py
File tests/beeswax/impala_beeswax.py:
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/beeswax/impala_beeswax.py@370
PS1, Line 370: wait_for_completion_timeout
Maybe this should be wait_for_finished, since the query isn't really "complete" in any meaningful sense. Same applies to the above method.
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/common/impala_connection.py@182
PS1, Line 182: def wait_for_completion_timeout(self, operation_handle, timeout):
Same comment
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/query_test/test_tablesample.py
File tests/query_test/test_tablesample.py:
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/query_test/test_tablesample.py@63
PS1, Line 63: timed_out
Isn't this the opposite of timed out? I.e. True means success, False means it timed out.
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 21:42:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2767/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 23:26:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6352: Dump backtrace on failure of TestTableSample
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10851 )
Change subject: IMPALA-6352: Dump backtrace on failure of TestTableSample
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/beeswax/impala_beeswax.py
File tests/beeswax/impala_beeswax.py:
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/beeswax/impala_beeswax.py@370
PS1, Line 370: wait_for_completion_timeout
> Maybe this should be wait_for_finished, since the query isn't really "compl
Done
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/common/impala_connection.py@182
PS1, Line 182: def wait_for_completion_timeout(self, operation_handle, timeout):
> Same comment
Done
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/query_test/test_tablesample.py
File tests/query_test/test_tablesample.py:
http://gerrit.cloudera.org:8080/#/c/10851/1/tests/query_test/test_tablesample.py@63
PS1, Line 63: timed_out
> Isn't this the opposite of timed out? I.e. True means success, False means
Done
--
To view, visit http://gerrit.cloudera.org:8080/10851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73fcdd30863cee105584c947bb0c48cf872809c1
Gerrit-Change-Number: 10851
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Jul 2018 22:11:32 +0000
Gerrit-HasComments: Yes