You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2023/07/28 16:40:37 UTC
[GitHub] [hudi] xuzifu666 opened a new pull request, #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
xuzifu666 opened a new pull request, #9309:
URL: https://github.com/apache/hudi/pull/9309
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
[HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
### Impact
_Describe any public API or user-facing feature change or any performance impact._
none
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278674892
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java:
##########
@@ -163,6 +163,7 @@ private void updateHeartbeat() throws HoodieHeartbeatException {
private void updateHeartbeat(Path heartbeatFilePath) throws HoodieHeartbeatException {
try (OutputStream outputStream = this.fs.create(heartbeatFilePath, true)) {
+ LOG.debug("create hearbeat file in path: {}", heartbeatFilePath);
} catch (IOException io) {
throw new HoodieHeartbeatException("Unable to generate heartbeat for file path " + heartbeatFilePath, io);
Review Comment:
yes, add the comments already @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1655987524
@yihua have a review plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1656740248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f60e915af0fbba2c29c09e172130417fcb8c19 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876)
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* 8d97f4bf072839974ce4563d24d67c2d123258fd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1656066520
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f60e915af0fbba2c29c09e172130417fcb8c19 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657657488
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
}, {
"hash" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18906",
"triggerID" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"triggerType" : "PUSH"
}, {
"hash" : "ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18911",
"triggerID" : "ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* 393e74176f72ad0b19dd8dc3ac1543156ad6d259 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18906)
* ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18911)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657174585
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* 8d97f4bf072839974ce4563d24d67c2d123258fd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882)
* e4f16c0cc7537241fa7e92e92d24b6b837e555d8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278783977
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java:
##########
@@ -163,6 +163,7 @@ private void updateHeartbeat() throws HoodieHeartbeatException {
private void updateHeartbeat(Path heartbeatFilePath) throws HoodieHeartbeatException {
try (OutputStream outputStream = this.fs.create(heartbeatFilePath, true)) {
+ LOG.debug("create hearbeat file in path: {}", heartbeatFilePath);
} catch (IOException io) {
throw new HoodieHeartbeatException("Unable to generate heartbeat for file path " + heartbeatFilePath, io);
Review Comment:
I mean to replace the debug log with a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #9309: [HUDI-6605] Write handlers not close with try block in ClientIds
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #9309:
URL: https://github.com/apache/hudi/pull/9309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1656264406
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f60e915af0fbba2c29c09e172130417fcb8c19 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657643308
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
}, {
"hash" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18906",
"triggerID" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"triggerType" : "PUSH"
}, {
"hash" : "ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* e4f16c0cc7537241fa7e92e92d24b6b837e555d8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900)
* 393e74176f72ad0b19dd8dc3ac1543156ad6d259 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18906)
* ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278283081
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,13 +190,12 @@ private Option<Path> create(Path markerPath, boolean checkIfExists) {
} catch (IOException e) {
throw new HoodieIOException("Failed to make dir " + dirPath, e);
}
- try {
+ try (FSDataOutputStream fsDataOutputStream = fs.create(markerPath, false)) {
if (checkIfExists && fs.exists(markerPath)) {
LOG.warn("Marker Path=" + markerPath + " already exists, cancel creation");
Review Comment:
The logic is not equivalent with before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1656731010
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f60e915af0fbba2c29c09e172130417fcb8c19 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876)
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* 8d97f4bf072839974ce4563d24d67c2d123258fd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278674301
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/ClientIds.java:
##########
@@ -163,6 +163,7 @@ private void updateHeartbeat() throws HoodieHeartbeatException {
private void updateHeartbeat(Path heartbeatFilePath) throws HoodieHeartbeatException {
try (OutputStream outputStream = this.fs.create(heartbeatFilePath, true)) {
+ LOG.debug("create hearbeat file in path: {}", heartbeatFilePath);
} catch (IOException io) {
throw new HoodieHeartbeatException("Unable to generate heartbeat for file path " + heartbeatFilePath, io);
Review Comment:
Does a comment work here?
```java
// no operation
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657405620
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
}, {
"hash" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18906",
"triggerID" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* e4f16c0cc7537241fa7e92e92d24b6b837e555d8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900)
* 393e74176f72ad0b19dd8dc3ac1543156ad6d259 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18906)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278291191
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,13 +190,12 @@ private Option<Path> create(Path markerPath, boolean checkIfExists) {
} catch (IOException e) {
throw new HoodieIOException("Failed to make dir " + dirPath, e);
}
- try {
+ try (FSDataOutputStream fsDataOutputStream = fs.create(markerPath, false)) {
if (checkIfExists && fs.exists(markerPath)) {
LOG.warn("Marker Path=" + markerPath + " already exists, cancel creation");
Review Comment:
ok, i restore it @danny0405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278476620
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,13 +190,12 @@ private Option<Path> create(Path markerPath, boolean checkIfExists) {
} catch (IOException e) {
throw new HoodieIOException("Failed to make dir " + dirPath, e);
}
- try {
+ try (FSDataOutputStream fsDataOutputStream = fs.create(markerPath, false)) {
Review Comment:
> This has to come after checking if the marker path already exists.
yes， so i remove it @yihua
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,13 +190,12 @@ private Option<Path> create(Path markerPath, boolean checkIfExists) {
} catch (IOException e) {
throw new HoodieIOException("Failed to make dir " + dirPath, e);
}
- try {
+ try (FSDataOutputStream fsDataOutputStream = fs.create(markerPath, false)) {
Review Comment:
> This has to come after checking if the marker path already exists.
yes， so i remove it @yihua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657172858
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* 8d97f4bf072839974ce4563d24d67c2d123258fd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882)
* e4f16c0cc7537241fa7e92e92d24b6b837e555d8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278291191
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,13 +190,12 @@ private Option<Path> create(Path markerPath, boolean checkIfExists) {
} catch (IOException e) {
throw new HoodieIOException("Failed to make dir " + dirPath, e);
}
- try {
+ try (FSDataOutputStream fsDataOutputStream = fs.create(markerPath, false)) {
if (checkIfExists && fs.exists(markerPath)) {
LOG.warn("Marker Path=" + markerPath + " already exists, cancel creation");
Review Comment:
ok, i restore it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1656791921
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* 8d97f4bf072839974ce4563d24d67c2d123258fd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1656040484
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f60e915af0fbba2c29c09e172130417fcb8c19 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657992541
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
}, {
"hash" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18906",
"triggerID" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"triggerType" : "PUSH"
}, {
"hash" : "ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18911",
"triggerID" : "ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* ea3bd74279a8c91b922f7b4800c2d409ee5fb5d6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18911)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278203823
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,13 +190,12 @@ private Option<Path> create(Path markerPath, boolean checkIfExists) {
} catch (IOException e) {
throw new HoodieIOException("Failed to make dir " + dirPath, e);
}
- try {
+ try (FSDataOutputStream fsDataOutputStream = fs.create(markerPath, false)) {
Review Comment:
This has to come after checking if the marker path already exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657202641
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* e4f16c0cc7537241fa7e92e92d24b6b837e555d8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1657400623
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
}, {
"hash" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18882",
"triggerID" : "8d97f4bf072839974ce4563d24d67c2d123258fd",
"triggerType" : "PUSH"
}, {
"hash" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900",
"triggerID" : "e4f16c0cc7537241fa7e92e92d24b6b837e555d8",
"triggerType" : "PUSH"
}, {
"hash" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "393e74176f72ad0b19dd8dc3ac1543156ad6d259",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
* e4f16c0cc7537241fa7e92e92d24b6b837e555d8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18900)
* 393e74176f72ad0b19dd8dc3ac1543156ad6d259 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #9309:
URL: https://github.com/apache/hudi/pull/9309#issuecomment-1656729030
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876",
"triggerID" : "74f60e915af0fbba2c29c09e172130417fcb8c19",
"triggerType" : "PUSH"
}, {
"hash" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "27a74b410d3c38b4e4d02edbf39a39f0d3fae835",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f60e915af0fbba2c29c09e172130417fcb8c19 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=18876)
* 27a74b410d3c38b4e4d02edbf39a39f0d3fae835 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org