You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/07/23 22:24:01 UTC
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11022
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Also, cleaned up confusing examples.
Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
---
M docs/topics/impala_char.xml
1 file changed, 75 insertions(+), 141 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11022/1
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml
File docs/topics/impala_char.xml:
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@93
PS1, Line 93: Therefore, <codeph>LENGTH()</codeph> represents the
: length including any trailing spaces,
> I think this is backwards - LENGTH() strips off trailing spaces. CHAR_LENGT
Done
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@99
PS1, Line 99: Retruns
> typo: Returns
Done
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 00:09:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 00:28:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/354/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 00:28:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Also, cleaned up confusing examples.
Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Reviewed-on: http://gerrit.cloudera.org:8080/11022
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_char.xml
1 file changed, 92 insertions(+), 141 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 00:35:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 00:12:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Balazs Jeszenszky, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11022
to look at the new patch set (#2).
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Also, cleaned up confusing examples.
Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
---
M docs/topics/impala_char.xml
1 file changed, 92 insertions(+), 141 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/11022/2
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7291: [DOCS] Note about no codegen support for CHAR
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11022 )
Change subject: IMPALA-7291: [DOCS] Note about no codegen support for CHAR
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml
File docs/topics/impala_char.xml:
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@93
PS1, Line 93: Therefore, <codeph>LENGTH()</codeph> represents the
: length including any trailing spaces,
I think this is backwards - LENGTH() strips off trailing spaces. CHAR_LENGTH() is the alternative version that doesn't:
[localhost:21000] default> select length(cast('test' as char(10)));
Query: select length(cast('test' as char(10)))
Query submitted at: 2018-07-23 16:19:11 (Coordinator: http://tarmstrong-box:25000)
Query progress can be monitored at: http://tarmstrong-box:25000/query_plan?query_id=643b0d940529bcf:2872caec00000000
+----------------------------------+
| length(cast('test' as char(10))) |
+----------------------------------+
| 4 |
+----------------------------------+
Fetched 1 row(s) in 0.12s
[localhost:21000] default> select char_length(cast('test' as char(10)));
Query: select char_length(cast('test' as char(10)))
Query submitted at: 2018-07-23 16:19:36 (Coordinator: http://tarmstrong-box:25000)
Query progress can be monitored at: http://tarmstrong-box:25000/query_plan?query_id=a046dffe3b57352f:4acea77600000000
+---------------------------------------+
| char_length(cast('test' as char(10))) |
+---------------------------------------+
| 10 |
+---------------------------------------+
Fetched 1 row(s) in 0.11s
http://gerrit.cloudera.org:8080/#/c/11022/1/docs/topics/impala_char.xml@99
PS1, Line 99: Retruns
typo: Returns
--
To view, visit http://gerrit.cloudera.org:8080/11022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id89dcf44e31f1bc56d888527585b3ec90229981a
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Jul 2018 23:21:36 +0000
Gerrit-HasComments: Yes