You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/18 20:57:54 UTC

[GitHub] [maven] kwart commented on a diff in pull request #773: [MNG-7511] Ensure the degreeOfConcurrency is a positive number (3.9.x)

kwart commented on code in PR #773:
URL: https://github.com/apache/maven/pull/773#discussion_r923854420


##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -371,4 +375,20 @@ public void testVersionStringWithoutAnsi() throws Exception
         assertEquals( MessageUtils.stripAnsiCodes( versionOut ), versionOut );
     }
 
+    class ConcurrencyCalculator implements ThrowingRunnable

Review Comment:
   I guess so if we stick to Java 1.7 code level. It seems to be cleaner than anonymous classes used directly in the test method.
   The signature of the assert method is:  `<T extends Throwable> T assertThrows(Class<T>, ThrowingRunnable)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org