[GitHub] [cordova-docs] erisu commented on a change in pull request #991: Added Platform Pinning Docs

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #991: Added Platform Pinning Docs
URL: https://github.com/apache/cordova-docs/pull/991#discussion_r305239934
 
 

 ##########
 File path: www/docs/en/dev/platform_pinning/index.md
 ##########
 @@ -24,11 +24,11 @@ description: Cordova CLI pinned platform versions.
 
 ## Platform Pinning
 
-Cordova CLI pins the supported platform version in conjunction with the version of CLI that is being used.
+Cordova CLI manages a list of pinned Apache Cordova maintained platforms. When there is a major release of Cordova CLI, the platform's pinned version is updated to the latest major released version. Typically, the updating of this pin is made only on a major release of CLI. This is because the pinned versions are pinned with a caret `^` allowing CLI to continue to fetch new minor and patch releases of any given pinned platform.
 
 Review comment:
   I will leave that up to the developer to decide when they do the release.
   
   In most cases when we release a major CLI we had already released a major of each platform. There is typically no `.1` or `.2` or what ever at that time unless someone really screwed up a release or introduce a major break/security bug before CLI was released. Then yes the developer can start on that version...
   
   If for any reason a platform was not released, the developer could also decided at that time to update to the last release but I think it would look a bit ugly... Also people may feel at that point that past minors/patches are no longer consider supported when bumped. It more like a range of what works and currently supported with the know major CLI.
   
   Since we have the `^` it will always use latest minor/patch.
   
   Maybe it can be argued, if it works, to just drop the `^` and change the entire format to `8.x` then it is always major. But this is not something to discuss in a PR about what we have now for docs.
   
   Anyways there is many up to developer/releaser information and use cases. All this can be documented else where like contribute. I think all this is not necessary for end user to read. This generally outlines that we pin, when pins are updated, what would potential fetched.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org