You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/07/18 17:42:26 UTC

Review Request 12723: test for Script

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12723/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

a unit test for the most frequently used methods in the Script class


Diffs
-----

  utils/test/com/cloud/utils/ScriptTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12723/diff/


Testing
-------

yes, this is the test


Thanks,

Laszlo Hornyak


Re: Review Request 12723: test for Script

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12723/#review23834
-----------------------------------------------------------

Ship it!


commit 026be3015bc9da8a56f5dd23ca9532bdb057dcec -> 4.2
commit 76e283687f8a9014d85e766c2543f3c98dcb6062 -> master


- Prasanna Santhanam


On July 24, 2013, 5:42 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12723/
> -----------------------------------------------------------
> 
> (Updated July 24, 2013, 5:42 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> a unit test for the most frequently used methods in the Script class
> 
> 
> Diffs
> -----
> 
>   utils/test/com/cloud/utils/ScriptTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12723/diff/
> 
> 
> Testing
> -------
> 
> yes, this is the test
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Re: Review Request 12723: test for Script

Posted by Laszlo Hornyak <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12723/
-----------------------------------------------------------

(Updated July 24, 2013, 5:42 p.m.)


Review request for cloudstack and Prasanna Santhanam.


Repository: cloudstack-git


Description
-------

a unit test for the most frequently used methods in the Script class


Diffs
-----

  utils/test/com/cloud/utils/ScriptTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/12723/diff/


Testing
-------

yes, this is the test


Thanks,

Laszlo Hornyak