You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/23 20:18:13 UTC
Review Request 71147: Update config factory to set resource provider
reconciliation interval.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254
Repository: mesos
Description
-------
Update config factory to set resource provider reconciliation interval.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e
Diff: https://reviews.apache.org/r/71147/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71147: Update config factory to set resource
provider reconciliation interval.
Posted by Benjamin Bannier <bb...@apache.org>.
> On July 26, 2019, 6:38 a.m., Chun-Hung Hsiao wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 331 (patched)
> > <https://reviews.apache.org/r/71147/diff/1/?file=2157522#file2157522line332>
> >
> > I'm actually thinking about haveing a really short reconciliation interval for testing here, so certain tests won't wait for a long time. WDYT?
> >
> > Or, maybe we can inject proper reconciliation intervals only in the tests that checks for reconciliations.
This is exactly what is being done in the follow-up patch https://reviews.apache.org/r/71148/.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/#review216876
-----------------------------------------------------------
On July 29, 2019, 10:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71147/
> -----------------------------------------------------------
>
> (Updated July 29, 2019, 10:56 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update config factory to set resource provider reconciliation interval.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 69b59d48ceefebbb7accefe411c54ac5cecff1c3
>
>
> Diff: https://reviews.apache.org/r/71147/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71147: Update config factory to set resource
provider reconciliation interval.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/#review216876
-----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp
Lines 331 (patched)
<https://reviews.apache.org/r/71147/#comment304120>
I'm actually thinking about haveing a really short reconciliation interval for testing here, so certain tests won't wait for a long time. WDYT?
Or, maybe we can inject proper reconciliation intervals only in the tests that checks for reconciliations.
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71147/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 8:18 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update config factory to set resource provider reconciliation interval.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e
>
>
> Diff: https://reviews.apache.org/r/71147/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71147: Update config factory to set resource
provider reconciliation interval.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/#review217023
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 29, 2019, 8:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71147/
> -----------------------------------------------------------
>
> (Updated July 29, 2019, 8:56 a.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update config factory to set resource provider reconciliation interval.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 69b59d48ceefebbb7accefe411c54ac5cecff1c3
>
>
> Diff: https://reviews.apache.org/r/71147/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71147: Update config factory to set resource
provider reconciliation interval.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/
-----------------------------------------------------------
(Updated July 29, 2019, 10:56 a.m.)
Review request for mesos and Chun-Hung Hsiao.
Changes
-------
Rebased
Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254
Repository: mesos
Description
-------
Update config factory to set resource provider reconciliation interval.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp 69b59d48ceefebbb7accefe411c54ac5cecff1c3
Diff: https://reviews.apache.org/r/71147/diff/2/
Changes: https://reviews.apache.org/r/71147/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier