You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/15 17:41:37 UTC
[GitHub] [arrow] lidavidm opened a new pull request #11963: ARROW-15066: [C++] Enable use of OpenTelemetry from conda-forge
lidavidm opened a new pull request #11963:
URL: https://github.com/apache/arrow/pull/11963
This is intended to make usage a little easier by enabling you to use a pre-built package instead of having to compile it from source.
Changes:
- Factor nlohmann_json out so that it can also be found in the environment instead of having to be built
- Call find_curl since OpenTelemetry's CMake files do not do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1065208554
Looks like nightly failures are generally unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1065556660
Benchmark runs are scheduled for baseline = dc2e0b2e44fdaa3d5ad0bb358ff8ce9db3bc7416 and contender = 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2. 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/caf662b31bfd4b4983e13e1b5993fe9c...9aaaae954d554cc7b8f273a5ee29928d/)
[Finished :arrow_down:0.08% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b503635258544201a1d7b1f86e8f21f6...78a4bdb2f0444c24a09e0416a45ebb38/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04cc8f678c414811b792ca5bc0eb721b...127102d9fbd04cc6bdc47fae1c552da3/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9bae67a8d2f6449fbbe47335346d274a...bd71ecc6d47f4f20a08850a4ecc22a53/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1061822666
Revision: 13b7a23e22332cbcfa89ae4e12a772d13ec39a4d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1728](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1728)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1728-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1728-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mbrobbel commented on pull request #11963: ARROW-15066: [C++] Enable use of OpenTelemetry from conda-forge
Posted by GitBox <gi...@apache.org>.
mbrobbel commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1028723729
Reminder to enable this: https://github.com/apache/arrow/pull/12322/commits/ad470f6aa253f83497f4bb4dabeb6b647518c960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of OpenTelemetry from conda-forge
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-995017859
https://issues.apache.org/jira/browse/ARROW-15066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1062276035
Revision: 93883c5fc1ff106eeebed846b140c0c5b6d71503
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1731](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1731)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1731-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1731-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1061811487
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1062274860
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1060985702
Revision: 6b3444f66bc09e9aeee69cee8118857ab2314f9a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1724](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1724)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1724-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1724-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
kou closed pull request #11963:
URL: https://github.com/apache/arrow/pull/11963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#discussion_r821713721
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3749,36 +3754,42 @@ macro(build_crc32c_once)
endif()
endmacro()
-macro(build_nlohmann_json_once)
- if(NOT TARGET nlohmann_json_ep)
- message(STATUS "Building nlohmann-json from source")
- # "Build" nlohmann-json
- set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
- set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
- set(NLOHMANN_JSON_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
- -DBUILD_TESTING=OFF -DJSON_BuildTests=OFF)
+macro(build_nlohmann_json)
+ message(STATUS "Building nlohmann-json from source")
+ # "Build" nlohmann-json
+ set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
+ set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
+ set(NLOHMANN_JSON_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>" -DBUILD_TESTING=OFF
+ -DJSON_BuildTests=OFF)
- set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
+ set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
- externalproject_add(nlohmann_json_ep
- ${EP_LOG_OPTIONS}
- INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
- URL ${NLOHMANN_JSON_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
+ externalproject_add(nlohmann_json_ep
+ ${EP_LOG_OPTIONS}
+ INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
+ URL ${NLOHMANN_JSON_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
- # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
- file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
+ # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
+ file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
- add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
- set_target_properties(nlohmann_json::nlohmann_json
- PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
- "${NLOHMANN_JSON_INCLUDE_DIR}")
- add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
- endif()
+ add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
+ set_target_properties(nlohmann_json::nlohmann_json
+ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
+ "${NLOHMANN_JSON_INCLUDE_DIR}")
+ add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
endmacro()
+if(ARROW_WITH_NLOHMANN_JSON)
+ set(nlohmann_json_SOURCE "AUTO")
Review comment:
Hmm, no, it is necessary after all. I suppose when some things are bundled and others aren't, this is needed to make it look for nlohmann_json, and fall back on building it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#discussion_r823878248
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3749,36 +3754,42 @@ macro(build_crc32c_once)
endif()
endmacro()
-macro(build_nlohmann_json_once)
- if(NOT TARGET nlohmann_json_ep)
- message(STATUS "Building nlohmann-json from source")
- # "Build" nlohmann-json
- set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
- set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
- set(NLOHMANN_JSON_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
- -DBUILD_TESTING=OFF -DJSON_BuildTests=OFF)
+macro(build_nlohmann_json)
+ message(STATUS "Building nlohmann-json from source")
+ # "Build" nlohmann-json
+ set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
+ set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
+ set(NLOHMANN_JSON_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>" -DBUILD_TESTING=OFF
+ -DJSON_BuildTests=OFF)
- set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
+ set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
- externalproject_add(nlohmann_json_ep
- ${EP_LOG_OPTIONS}
- INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
- URL ${NLOHMANN_JSON_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
+ externalproject_add(nlohmann_json_ep
+ ${EP_LOG_OPTIONS}
+ INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
+ URL ${NLOHMANN_JSON_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
- # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
- file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
+ # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
+ file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
- add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
- set_target_properties(nlohmann_json::nlohmann_json
- PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
- "${NLOHMANN_JSON_INCLUDE_DIR}")
- add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
- endif()
+ add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
+ set_target_properties(nlohmann_json::nlohmann_json
+ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
+ "${NLOHMANN_JSON_INCLUDE_DIR}")
+ add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
endmacro()
+if(ARROW_WITH_NLOHMANN_JSON)
+ set(nlohmann_json_SOURCE "AUTO")
Review comment:
Thanks for the explanation, I've updated the Fedora/MSYS/Debian/Ubuntu dockerfiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of OpenTelemetry from conda-forge
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1039065591
@xhochy sorry, this is more like "test with the conda-forge packages and make any changes necessary to get them to work"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11963: ARROW-15066: [C++] Enable use of OpenTelemetry from conda-forge
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1040582808
In any case, there are conflicts that need to be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1065556660
Benchmark runs are scheduled for baseline = dc2e0b2e44fdaa3d5ad0bb358ff8ce9db3bc7416 and contender = 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2. 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/caf662b31bfd4b4983e13e1b5993fe9c...9aaaae954d554cc7b8f273a5ee29928d/)
[Finished :arrow_down:0.08% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b503635258544201a1d7b1f86e8f21f6...78a4bdb2f0444c24a09e0416a45ebb38/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04cc8f678c414811b792ca5bc0eb721b...127102d9fbd04cc6bdc47fae1c552da3/)
[Finished :arrow_down:0.09% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9bae67a8d2f6449fbbe47335346d274a...bd71ecc6d47f4f20a08850a4ecc22a53/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1064641585
```
No such option: -g
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/1966197632```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1060978154
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1060977907
Thanks, rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1062957804
Revision: 1b5183e8e8cbbe307bcf0ff8de0e9eb8f6b413a5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1736](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1736)
|Task|Status|
|----|------|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1736-github-test-fedora-33-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1040856375
Sorry, I've rebased + changed the title to hopefully be less confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1065556660
Benchmark runs are scheduled for baseline = dc2e0b2e44fdaa3d5ad0bb358ff8ce9db3bc7416 and contender = 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2. 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/caf662b31bfd4b4983e13e1b5993fe9c...9aaaae954d554cc7b8f273a5ee29928d/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b503635258544201a1d7b1f86e8f21f6...78a4bdb2f0444c24a09e0416a45ebb38/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04cc8f678c414811b792ca5bc0eb721b...127102d9fbd04cc6bdc47fae1c552da3/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9bae67a8d2f6449fbbe47335346d274a...bd71ecc6d47f4f20a08850a4ecc22a53/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1064653767
Revision: 6095fdd71e0a7a3fd7158c6818cfb61586a7b061
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1751](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1751)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-almalinux-8-amd64)|
|almalinux-8-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|amazon-linux-2-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-amazon-linux-2-amd64)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-centos-7-amd64)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-clean)|
|conda-linux-gcc-py310-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py310-arm64)|
|conda-linux-gcc-py310-cpu|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py310-cpu)|
|conda-linux-gcc-py310-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py310-cuda)|
|conda-linux-gcc-py310-ppc64le|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py310-ppc64le)|
|conda-linux-gcc-py37-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py37-arm64)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-linux-gcc-py37-cpu-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py37-cpu-r41)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py37-ppc64le|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py37-ppc64le)|
|conda-linux-gcc-py38-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py38-arm64)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py38-cuda)|
|conda-linux-gcc-py38-ppc64le|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py38-ppc64le)|
|conda-linux-gcc-py39-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py39-arm64)|
|conda-linux-gcc-py39-cpu|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py39-cpu)|
|conda-linux-gcc-py39-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py39-cuda)|
|conda-linux-gcc-py39-ppc64le|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-linux-gcc-py39-ppc64le)|
|conda-osx-arm64-clang-py310|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-arm64-clang-py310)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py310|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-clang-py310)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-clang-py37-r41)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py310|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-win-vs2017-py310)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-win-vs2017-py37-r40)|
|conda-win-vs2017-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-win-vs2017-py37-r41)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-win-vs2017-py38)|
|conda-win-vs2017-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-conda-win-vs2017-py39)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-debian-bookworm-amd64)|
|debian-bookworm-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-example-cpp-minimal-build-static-system-dependency)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-homebrew-r-autobrew)|
|homebrew-r-brew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-homebrew-r-brew)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-java-jars)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-python-sdist)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-build-cpp-fuzz)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-conda-cpp-valgrind)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.10)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-hdfs-3.2.1)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-pandas-0.24)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-spark-v3.1.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-spark-v3.1.2)|
|test-conda-python-3.7-turbodbc-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-turbodbc-latest)|
|test-conda-python-3.7-turbodbc-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.7-turbodbc-master)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.8)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-v3.2.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.8-spark-v3.2.0)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.9)|
|test-conda-python-3.9-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.9-dask-latest)|
|test-conda-python-3.9-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.9-dask-master)|
|test-conda-python-3.9-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.9-pandas-master)|
|test-conda-python-3.9-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-conda-python-3.9-spark-master)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-debian-11-cpp-i386)|
|test-debian-11-go-1.16|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-debian-11-go-1.16)|
|test-debian-11-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-debian-11-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-fedora-33-python-3)|
|test-fedora-r-clang-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-fedora-r-clang-sanitizer)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-arrow-backwards-compatibility)|
|test-r-depsource-bundled|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-depsource-bundled)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-depsource-system)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-dev-duckdb)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-minimal-build)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-offline-maximal)|
|test-r-offline-minimal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-offline-minimal)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-rhub-debian-gcc-devel-lto-latest)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-4.1-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-rstudio-r-base-4.1-centos7-devtoolset-8)|
|test-r-rstudio-r-base-4.1-focal|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-rstudio-r-base-4.1-focal)|
|test-r-rstudio-r-base-4.1-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-rstudio-r-base-4.1-opensuse15)|
|test-r-rstudio-r-base-4.1-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-r-rstudio-r-base-4.1-opensuse42)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-ubuntu-21.04)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-r-versions)|
|test-skyhook-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-skyhook-integration)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-20.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-ubuntu-20.04-python-3)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-21.04-cpp)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-c-glib)|
|test-ubuntu-default-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1751-azure-test-ubuntu-default-docs)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-hirsute-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-ubuntu-hirsute-amd64)|
|ubuntu-hirsute-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|ubuntu-impish-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-ubuntu-impish-amd64)|
|ubuntu-impish-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-cpp-linux-almalinux-8-amd64)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-cpp-linux-conda-latest-amd64)|
|verify-rc-source-cpp-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-cpp-linux-ubuntu-18.04-amd64)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-cpp-linux-ubuntu-20.04-amd64)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-cpp-macos-amd64)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-cpp-macos-arm64)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-cpp-macos-conda-amd64)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-csharp-linux-almalinux-8-amd64)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-csharp-linux-conda-latest-amd64)|
|verify-rc-source-csharp-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-csharp-linux-ubuntu-18.04-amd64)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-csharp-linux-ubuntu-20.04-amd64)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-csharp-macos-amd64)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-csharp-macos-arm64)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-go-linux-almalinux-8-amd64)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-go-linux-conda-latest-amd64)|
|verify-rc-source-go-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-go-linux-ubuntu-18.04-amd64)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-go-linux-ubuntu-20.04-amd64)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-go-macos-amd64)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-go-macos-arm64)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-integration-linux-almalinux-8-amd64)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-integration-linux-conda-latest-amd64)|
|verify-rc-source-integration-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-integration-linux-ubuntu-18.04-amd64)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-integration-linux-ubuntu-20.04-amd64)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-integration-macos-amd64)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-integration-macos-arm64)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-integration-macos-conda-amd64)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-java-linux-almalinux-8-amd64)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-java-linux-conda-latest-amd64)|
|verify-rc-source-java-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-java-linux-ubuntu-18.04-amd64)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-java-linux-ubuntu-20.04-amd64)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-java-macos-amd64)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-js-linux-almalinux-8-amd64)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-js-linux-conda-latest-amd64)|
|verify-rc-source-js-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-js-linux-ubuntu-18.04-amd64)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-js-linux-ubuntu-20.04-amd64)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-js-macos-amd64)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-js-macos-arm64)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-python-linux-almalinux-8-amd64)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-python-linux-conda-latest-amd64)|
|verify-rc-source-python-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-python-linux-ubuntu-18.04-amd64)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-python-linux-ubuntu-20.04-amd64)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-python-macos-amd64)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-python-macos-arm64)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-python-macos-conda-amd64)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-ruby-linux-almalinux-8-amd64)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-ruby-linux-conda-latest-amd64)|
|verify-rc-source-ruby-linux-ubuntu-18.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-ruby-linux-ubuntu-18.04-amd64)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-ruby-linux-ubuntu-20.04-amd64)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-ruby-macos-amd64)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-ruby-macos-arm64)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-verify-rc-source-windows)|
|wheel-macos-big-sur-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-big-sur-cp310-arm64)|
|wheel-macos-big-sur-cp310-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-big-sur-cp310-universal2)|
|wheel-macos-big-sur-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-big-sur-cp38-arm64)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-high-sierra-cp310-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-mavericks-cp310-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2010-cp310-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2014-cp310-amd64)|
|wheel-manylinux2014-cp310-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://app.travis-ci.com/github/ursacomputing/crossbow/branches)|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-windows-cp310-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1751-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1064653023
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1060927111
Revision: 15a8b017507eb91ed19be900b264193c5fff6327
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1722](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1722)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1722-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1722-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1062956451
@github-actions crossbow submit test-fedora-33-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1060974426
@lidavidm Perhaps you can rebase to get the latest build fixes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#discussion_r822089248
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3749,36 +3754,42 @@ macro(build_crc32c_once)
endif()
endmacro()
-macro(build_nlohmann_json_once)
- if(NOT TARGET nlohmann_json_ep)
- message(STATUS "Building nlohmann-json from source")
- # "Build" nlohmann-json
- set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
- set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
- set(NLOHMANN_JSON_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
- -DBUILD_TESTING=OFF -DJSON_BuildTests=OFF)
+macro(build_nlohmann_json)
+ message(STATUS "Building nlohmann-json from source")
+ # "Build" nlohmann-json
+ set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
+ set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
+ set(NLOHMANN_JSON_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>" -DBUILD_TESTING=OFF
+ -DJSON_BuildTests=OFF)
- set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
+ set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
- externalproject_add(nlohmann_json_ep
- ${EP_LOG_OPTIONS}
- INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
- URL ${NLOHMANN_JSON_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
+ externalproject_add(nlohmann_json_ep
+ ${EP_LOG_OPTIONS}
+ INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
+ URL ${NLOHMANN_JSON_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
- # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
- file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
+ # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
+ file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
- add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
- set_target_properties(nlohmann_json::nlohmann_json
- PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
- "${NLOHMANN_JSON_INCLUDE_DIR}")
- add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
- endif()
+ add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
+ set_target_properties(nlohmann_json::nlohmann_json
+ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
+ "${NLOHMANN_JSON_INCLUDE_DIR}")
+ add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
endmacro()
+if(ARROW_WITH_NLOHMANN_JSON)
+ set(nlohmann_json_SOURCE "AUTO")
Review comment:
I think that it's a problem of our CI configuration not the CMake code.
Some of our CI jobs uses `-DARROW_DEPENDENCY_SOURCE=SYSTEM` explicitly to use system libraries. For example: https://github.com/apache/arrow/runs/5465413563?check_suite_focus=true#step:6:1843
```text
cmake ... -DARROW_DEPENDENCY_SOURCE=SYSTEM ...
```
In the CI jobs, we must install `nlohmann-json` explicitly. e.g.:
* MSYS2: https://packages.msys2.org/base/mingw-w64-nlohmann-json
* Debian: https://packages.debian.org/search?keywords=nlohmann-json
* Ubuntu: https://packages.ubuntu.com/search?keywords=nlohmann-json
Here is a sample change for MSYS2:
```diff
diff --git a/ci/scripts/msys2_setup.sh b/ci/scripts/msys2_setup.sh
index 01cd5fa9ee..be6a947c6f 100755
--- a/ci/scripts/msys2_setup.sh
+++ b/ci/scripts/msys2_setup.sh
@@ -41,6 +41,7 @@ case "${target}" in
packages+=(${MINGW_PACKAGE_PREFIX}-make)
packages+=(${MINGW_PACKAGE_PREFIX}-mlir)
packages+=(${MINGW_PACKAGE_PREFIX}-ninja)
+ packages+=(${MINGW_PACKAGE_PREFIX}-nlohmann-json)
packages+=(${MINGW_PACKAGE_PREFIX}-polly)
packages+=(${MINGW_PACKAGE_PREFIX}-protobuf)
packages+=(${MINGW_PACKAGE_PREFIX}-python3-numpy)
```
If there isn't `nlohmann-json` package in the system, we need to specify `-Dnlohmann_json_SOURCE=BUNDLED` explicitly for the CI jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1065556660
Benchmark runs are scheduled for baseline = dc2e0b2e44fdaa3d5ad0bb358ff8ce9db3bc7416 and contender = 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2. 5592cf7cc7056679f1d7fd0ca2f9a9149e97b5c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/caf662b31bfd4b4983e13e1b5993fe9c...9aaaae954d554cc7b8f273a5ee29928d/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b503635258544201a1d7b1f86e8f21f6...78a4bdb2f0444c24a09e0416a45ebb38/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/04cc8f678c414811b792ca5bc0eb721b...127102d9fbd04cc6bdc47fae1c552da3/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9bae67a8d2f6449fbbe47335346d274a...bd71ecc6d47f4f20a08850a4ecc22a53/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1060925610
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1064641292
@github-actions crossbow -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#discussion_r821686738
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3749,36 +3754,42 @@ macro(build_crc32c_once)
endif()
endmacro()
-macro(build_nlohmann_json_once)
- if(NOT TARGET nlohmann_json_ep)
- message(STATUS "Building nlohmann-json from source")
- # "Build" nlohmann-json
- set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
- set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
- set(NLOHMANN_JSON_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
- -DBUILD_TESTING=OFF -DJSON_BuildTests=OFF)
+macro(build_nlohmann_json)
+ message(STATUS "Building nlohmann-json from source")
+ # "Build" nlohmann-json
+ set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
+ set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
+ set(NLOHMANN_JSON_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>" -DBUILD_TESTING=OFF
+ -DJSON_BuildTests=OFF)
- set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
+ set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
- externalproject_add(nlohmann_json_ep
- ${EP_LOG_OPTIONS}
- INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
- URL ${NLOHMANN_JSON_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
+ externalproject_add(nlohmann_json_ep
+ ${EP_LOG_OPTIONS}
+ INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
+ URL ${NLOHMANN_JSON_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
- # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
- file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
+ # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
+ file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
- add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
- set_target_properties(nlohmann_json::nlohmann_json
- PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
- "${NLOHMANN_JSON_INCLUDE_DIR}")
- add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
- endif()
+ add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
+ set_target_properties(nlohmann_json::nlohmann_json
+ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
+ "${NLOHMANN_JSON_INCLUDE_DIR}")
+ add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
endmacro()
+if(ARROW_WITH_NLOHMANN_JSON)
+ set(nlohmann_json_SOURCE "AUTO")
Review comment:
We don't need it, you're right - removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11963: ARROW-15066: [C++] Enable use of non-bundled OpenTelemetry
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#discussion_r821661028
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -3749,36 +3754,42 @@ macro(build_crc32c_once)
endif()
endmacro()
-macro(build_nlohmann_json_once)
- if(NOT TARGET nlohmann_json_ep)
- message(STATUS "Building nlohmann-json from source")
- # "Build" nlohmann-json
- set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
- set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
- set(NLOHMANN_JSON_CMAKE_ARGS
- ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>"
- -DBUILD_TESTING=OFF -DJSON_BuildTests=OFF)
+macro(build_nlohmann_json)
+ message(STATUS "Building nlohmann-json from source")
+ # "Build" nlohmann-json
+ set(NLOHMANN_JSON_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/nlohmann_json_ep-install")
+ set(NLOHMANN_JSON_INCLUDE_DIR "${NLOHMANN_JSON_PREFIX}/include")
+ set(NLOHMANN_JSON_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS} "-DCMAKE_INSTALL_PREFIX=<INSTALL_DIR>" -DBUILD_TESTING=OFF
+ -DJSON_BuildTests=OFF)
- set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
+ set(NLOHMANN_JSON_BUILD_BYPRODUCTS ${NLOHMANN_JSON_PREFIX}/include/nlohmann/json.hpp)
- externalproject_add(nlohmann_json_ep
- ${EP_LOG_OPTIONS}
- INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
- URL ${NLOHMANN_JSON_SOURCE_URL}
- URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
- CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
- BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
+ externalproject_add(nlohmann_json_ep
+ ${EP_LOG_OPTIONS}
+ INSTALL_DIR ${NLOHMANN_JSON_PREFIX}
+ URL ${NLOHMANN_JSON_SOURCE_URL}
+ URL_HASH "SHA256=${ARROW_NLOHMANN_JSON_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${NLOHMANN_JSON_CMAKE_ARGS}
+ BUILD_BYPRODUCTS ${NLOHMANN_JSON_BUILD_BYPRODUCTS})
- # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
- file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
+ # Work around https://gitlab.kitware.com/cmake/cmake/issues/15052
+ file(MAKE_DIRECTORY ${NLOHMANN_JSON_INCLUDE_DIR})
- add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
- set_target_properties(nlohmann_json::nlohmann_json
- PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
- "${NLOHMANN_JSON_INCLUDE_DIR}")
- add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
- endif()
+ add_library(nlohmann_json::nlohmann_json INTERFACE IMPORTED)
+ set_target_properties(nlohmann_json::nlohmann_json
+ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
+ "${NLOHMANN_JSON_INCLUDE_DIR}")
+ add_dependencies(nlohmann_json::nlohmann_json nlohmann_json_ep)
endmacro()
+if(ARROW_WITH_NLOHMANN_JSON)
+ set(nlohmann_json_SOURCE "AUTO")
Review comment:
Why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #11963: ARROW-15066: [C++] Enable use of OpenTelemetry from conda-forge
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1040582808
In any case, there are conflicts that need to be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #11963: ARROW-15066: [C++] Enable use of OpenTelemetry from conda-forge
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #11963:
URL: https://github.com/apache/arrow/pull/11963#issuecomment-1038845631
@lidavidm I'm a bit confused about how this PR is related to the packages in conda-forge. Can you enlighten me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org