You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Remilito <gi...@git.apache.org> on 2017/02/20 15:42:57 UTC
[GitHub] zeppelin pull request #2043: [ZEPPELIN-2114] adding reload endpoint
GitHub user Remilito opened a pull request:
https://github.com/apache/zeppelin/pull/2043
[ZEPPELIN-2114] adding reload endpoint
### What is this PR for?
Adding endpoint in NotebookRepoRestApi to trigger reload and broadcast of the note list.
Sending a GET request to /api/notebook-repositories/reload will trigger a reload of the note list, just like the reload button does on the homepage.
Q: If you think this endpoint belongs to another API (NotebookRestApi?), let me know.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
<https://issues.apache.org/jira/browse/ZEPPELIN-2114>
### How should this be tested?
0. add (or remove) a note in the notebook repository
1. curl -X GET http://HOST:PORT/api/notebook-repository/reload
2. verify that you the note list in Zeppelin's home page now contains (or does not contain anymore) the note.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NotebookRepoRestApi does not have documentation yet. Could add it in another PR if needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2043.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2043
----
commit cf66c2b7f180a952c2b7fef8ac901bf1da484a57
Author: Remilito <re...@gmail.com>
Date: 2017-02-20T14:43:25Z
[ZEPPELIN-2114] adding reload endpoint
* ability to reload note list from repo by API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2043: [ZEPPELIN-2114] adding reload endpoint
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2043
>If you think this endpoint belongs to another API (NotebookRestApi?), let me know.
I think `notebook-repositories` is right place for this as you did.
@Leemoonsoo It would be better to have separated docs page for "NotebookRepo". Since it's start \w `api/notebook-repositories` whereas "NotebookRestApi" start \w `api/notebook`. I created issue for this [ZEPPELIN-2140](https://issues.apache.org/jira/browse/ZEPPELIN-2140). I'll handle it in another PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2043: [ZEPPELIN-2114] adding reload endpoint
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2043
@Remilito Sorry for my late response. Tested and it works as expected.
Regarding the docs that I mentioned was added in #2067. Will be appreciated if you can take a look :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2043: [ZEPPELIN-2114] adding reload endpoint
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2043
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2043: [ZEPPELIN-2114] adding reload endpoint
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2043
Merge into master and branch-0.7 if there are no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2043: [ZEPPELIN-2114] adding reload endpoint
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2043
Thanks for the contribution.
Do you mind add a documentation [here](https://github.com/apache/zeppelin/blob/master/docs/rest-api/rest-notebook.md) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2043: [ZEPPELIN-2114] adding reload endpoint
Posted by Remilito <gi...@git.apache.org>.
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2043
@AhyoungRyu: let me know if need me to enrich the new notebook-repositories doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---