You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "xxjingcd (via GitHub)" <gi...@apache.org> on 2023/02/01 11:41:44 UTC

[GitHub] [dolphinscheduler] xxjingcd opened a new pull request, #13490: [Improvement-12528][logger] Achieve config task log base path out of the dolphinscheduler install path

xxjingcd opened a new pull request, #13490:
URL: https://github.com/apache/dolphinscheduler/pull/13490

   …hinscheduler install path;
   
   
   
   <!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
   
   ## Purpose of the pull request
   
   Achieve config task log base path out of the dolphinscheduler install path; 
   
   This closes issue This closes issue #12528 #12703 #13460 #13461
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   Add task log directory variable in `application.yaml` of Master and Worker ;  
   
   ```yaml
   task:
     logger-dir:
       # The task log directory currently in use
       current: logs
       # The task log directory used in the past; You can have multiple values, separated by commas;
       past:
   ```
    
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
   - [LoggerRequestProcessorTest.java](https://github.com/apache/dolphinscheduler/compare/dev...xxjingcd:dolphinscheduler:Improvement-12528?expand=1#diff-e124d8b3ada308c59781552346e9705aa5e0f5f0dd8c047973fc65377c2cb534)
   
   <!--*(example:)*
   - *Added dolphinscheduler-dao tests for end-to-end.*
   - *Added CronUtilsTest to verify the change.*
   - *Manually verified the change by testing locally.* -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun closed pull request #13490: [Improvement-12528][logger] Achieve config task log base path out of the dolphinscheduler install path

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun closed pull request #13490: [Improvement-12528][logger] Achieve config task log base path out of the dolphinscheduler install path
URL: https://github.com/apache/dolphinscheduler/pull/13490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] xxjingcd commented on pull request #13490: [Improvement-12528][logger] Achieve config task log base path out of the dolphinscheduler install path

Posted by "xxjingcd (via GitHub)" <gi...@apache.org>.
xxjingcd commented on PR #13490:
URL: https://github.com/apache/dolphinscheduler/pull/13490#issuecomment-1413033223

   @xxjingcd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #13490: [Improvement-12528][logger] Achieve config task log base path out of the dolphinscheduler install path

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #13490:
URL: https://github.com/apache/dolphinscheduler/pull/13490#issuecomment-1411931885

   The security check has been removed, we don't need this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] xxjingcd commented on pull request #13490: [Improvement-12528][logger] Achieve config task log base path out of the dolphinscheduler install path

Posted by "xxjingcd (via GitHub)" <gi...@apache.org>.
xxjingcd commented on PR #13490:
URL: https://github.com/apache/dolphinscheduler/pull/13490#issuecomment-1413026020

   > The security check has been removed, we don't need this PR.
   
   Please turn to issue https://github.com/apache/dolphinscheduler/issues/13460 . And I have provided a attack example;
   
   @ruanwenjun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org