You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/22 18:07:33 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3443: HDDS-6786. Bad value for metric NumBytesCommittedCount in testContainerStateMachineMetrics
adoroszlai opened a new pull request, #3443:
URL: https://github.com/apache/ozone/pull/3443
## What changes were proposed in this pull request?
Fix:
```
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.107 s <<< FAILURE! - in org.apache.hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics
[ERROR] org.apache.hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics.testContainerStateMachineMetrics Time elapsed: 15.033 s <<< FAILURE!
java.lang.AssertionError: Bad value for metric NumBytesCommittedCount expected:<1024> but was:<0>
...
at org.apache.hadoop.test.MetricsAsserts.assertCounter(MetricsAsserts.java:230)
at org.apache.hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics.runContainerStateMachineMetrics(TestCSMMetrics.java:156)
at org.apache.hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics.testContainerStateMachineMetrics(TestCSMMetrics.java:89)
```
The test may reach metrics assertions in the main thread earlier than the state machine increases the byte counter in `ContainerOp` thread.
https://issues.apache.org/jira/browse/HDDS-6786
## How was this patch tested?
Repeated 100x without failure:
https://github.com/adoroszlai/hadoop-ozone/runs/6543225987
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2366748150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3443: HDDS-6786. Bad value for metric NumBytesCommittedCount in testContainerStateMachineMetrics
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3443:
URL: https://github.com/apache/ozone/pull/3443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3443: HDDS-6786. Bad value for metric NumBytesCommittedCount in testContainerStateMachineMetrics
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3443:
URL: https://github.com/apache/ozone/pull/3443#issuecomment-1134328280
Thanks @lokeshj1703 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org