[GitHub] [superset] junlincc commented on pull request #12582: fix(explore): Disable saved metric name edit in Metric popover

[GitBox <gi...@apache.org>]

junlincc commented on pull request #12582:
URL: https://github.com/apache/superset/pull/12582#issuecomment-762391555


   > It is a little strange to adjust the order of tabs depending on whether the dataset contains saved metrics or not.
   > 
   > thank you for your fix.
   
   right.......we should add tooltip or even enable user to save a ad hoc metric to saved metrics in the popover in the near future. 
   as i'm getting more familiar with Superset, i do see advanced and enterprise users tend to use saved metrics more often. placing Saved tab first in the modal can encourage users to use and create reusable metrics across team and organization. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org