You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Yuxin Tan (Jira)" <ji...@apache.org> on 2023/04/19 06:38:00 UTC

[jira] [Commented] (FLINK-30815) BatchTestBase/BatchAbstractTestBase are using JUnit4 while some child tests are using JUnit5

    [ https://issues.apache.org/jira/browse/FLINK-30815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713923#comment-17713923 ] 

Yuxin Tan commented on FLINK-30815:
-----------------------------------

[~zhuzh] Thanks for starting the issue, I will take a look at it.

> BatchTestBase/BatchAbstractTestBase are using JUnit4 while some child tests are using JUnit5
> --------------------------------------------------------------------------------------------
>
>                 Key: FLINK-30815
>                 URL: https://issues.apache.org/jira/browse/FLINK-30815
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.16.0
>            Reporter: Zhu Zhu
>            Assignee: Yuxin Tan
>            Priority: Major
>              Labels: pull-request-available
>
> BatchTestBase/BatchAbstractTestBase are using Junit4, while some child tests (e.g. DynamicFilteringITCase) are using JUnit5. This may break some assumption and hide some problems.
> For example, the child test will create a MiniCluster by itself, instead of using the MiniCluster(TM=1, slots=3)  created in BatchAbstractTestBase. The created MiniCluster may  have more slots and hide resource deadlock issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)