You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/06 13:26:06 UTC
[GitHub] [incubator-druid] superivaj opened a new pull request #8832: SQL
Server Metadata store fix
superivaj opened a new pull request #8832: SQL Server Metadata store fix
URL: https://github.com/apache/incubator-druid/pull/8832
### Description
The SQL Server Metadata store throws the following exception when creating a new compaction rule in the coordinator. This PR fixes the cause of this exception.
java.util.concurrent.ExecutionException: org.skife.jdbi.v2.exceptions.CallbackFailedException: org.skife.jdbi.v2.exceptions.UnableToExecuteStatementException: com.microsoft.sqlserver.jdbc.SQLServerException: Incorrect syntax near ','. [statement:"MERGE INTO druid_config WITH (UPDLOCK, HOLDLOCK) as target USING (:key, :value) as source (name, payload) ON (target.name = source.name) WHEN MATCHED THEN UPDATE SET payload = :value WHEN NOT MATCHED THEN INSERT (name, payload) VALUES (:key, :value)", located:"MERGE INTO druid_config WITH (UPDLOCK, HOLDLOCK) as target USING (:key, :value) as source (name, payload) ON (target.name = source.name) WHEN MATCHED THEN UPDATE SET payload = :value WHEN NOT MATCHED THEN INSERT (name, payload) VALUES (:key, :value)", rewritten:"MERGE INTO druid_config WITH (UPDLOCK, HOLDLOCK) as target USING (?, ?) as source (name, payload) ON (target.name = source.name) WHEN MATCHED THEN UPDATE SET payload = ? WHEN NOT MATCHED THEN INSERT (name, payload) VALUES (?, ?)", arguments:{ positional:{}, named:{value:[123, 34, 99, 111, 109, 112, 97, 99, 116, 105, 111, 110, 67, 111, 110, 102, 105, 103, 115, 34, 58, 91, 123, 34, 100, 97, 116, 97, 83, 111, 117, 114, 99, 101, 34, 58, 34, 101, 101, 95, 117, 107, 95, 97, 112, 116, 117, 115, 95, 49, 34, 44, 34, 116, 97, 115, 107, 80, 114, 105, 111, 114, 105, 116, 121, 34, 58, 50, 53, 44, 34, 105, 110, 112, 117, 116, 83, 101, 103, 109, 101, 110, 116, 83, 105, 122, 101, 66, 121, 116, 101, 115, 34, 58, 52, 49, 57, 52, 51, 48, 52, 48, 48, 44, 34, 116, 97, 114, 103, 101, 116, 67, 111, 109, 112, 97, 99, 116, 105, 111, 110, 83, 105, 122, 101, 66, 121, 116, 101, 115, 34, 58, 52, 49, 57, 52, 51, 48, 52, 48, 48, 44, 34, 109, 97, 120, 82, 111, 119, 115, 80, 101, 114, 83, 101, 103, 109, 101, 110, 116, 34, 58, 110, 117, 108, 108, 44, 34, 109, 97, 120, 78, 117, 109, 83, 101, 103, 109, 101, 110, 116, 115, 84, 111, 67, 111, 109, 112, 97, 99, 116, 34, 58, 49, 53, 48, 44, 34, 115, 107, 105, 112, 79, 102, 102, 115, 101, 116, 70, 114, 111, 109, 76, 97, 116, 101, 115, 116, 34, 58, 34, 80, 49, 68, 34, 44, 34, 116, 117, 110, 105, 110, 103, 67, 111, 110, 102, 105, 103, 34, 58, 110, 117, 108, 108, 44, 34, 116, 97, 115, 107, 67, 111, 110, 116, 101, 120, 116, 34, 58, 110, 117, 108, 108, 125, 93, 44, 34, 99, 111, 109, 112, 97, 99, 116, 105, 111, 110, 84, 97, 115, 107, 83, 108, 111, 116, 82, 97, 116, 105, 111, 34, 58, 48, 46, 49, 44, 34, 109, 97, 120, 67, 111, 109, 112, 97, 99, 116, 105, 111, 110, 84, 97, 115, 107, 83, 108, 111, 116, 115, 34, 58, 50, 49, 52, 55, 52, 56, 51, 54, 52, 55, 125],key:'coordinator.compaction.config'}, finder:[]}]
The patch fixes the SQL MERGE query that was wrongly written.
<hr>
This PR has:
- [x ] been self-reviewed.
- [ n/a] added documentation for new or modified features or behaviors.
- [n/a] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ n/a] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
- [n/a] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [n/a] added unit tests or modified existing tests to cover new code paths.
- [n/a] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
org.apache.druid.metadata.storage.sqlserver.SQLServerConnector
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org