You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/23 20:36:44 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2150: Do not pretend to cache rust build artifacts
alamb opened a new pull request, #2150:
URL: https://github.com/apache/arrow-rs/pull/2150
# Which issue does this PR close?
re https://github.com/apache/arrow-rs/issues/2149
# Rationale for this change
Caching rust build artifacts (aka the contents of `target`) is notoriously difficult (as the slightest change in various environments or dependencies often causes a significant recompile).
However, the CI jobs spent a non trivial amount of time attempting to cache the artifacts unsuccessfully (as my measurements below will show). Until someone has some time to get the caching working properly, I propose we simply stop trying and save ourselves some time (and github worker rate-limit credits)
# What changes are included in this PR?
Remove the `linux-build-lib` job as it gates other jobs from starting but does not save any time
# Are there any user-facing changes?
Hopefully faster CI
TODO: performance measurements before/after this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #2150: Do not pretend to cache rust build artifacts, speed up CI by ~20%
Posted by GitBox <gi...@apache.org>.
viirya merged PR #2150:
URL: https://github.com/apache/arrow-rs/pull/2150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2150: Do not pretend to cache rust build artifacts
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2150:
URL: https://github.com/apache/arrow-rs/pull/2150#issuecomment-1193187298
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2150?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2150](https://codecov.io/gh/apache/arrow-rs/pull/2150?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b327e4e) into [master](https://codecov.io/gh/apache/arrow-rs/commit/19a71899d828f1c6204c97542645fd801a848ceb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19a7189) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2150 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 237 237
Lines 61296 61296
=======================================
+ Hits 50792 50793 +1
+ Misses 10504 10503 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2150?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/2150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.43% <0.00%> (-0.20%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (+0.22%)` | :arrow_up: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2150/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `63.00% <0.00%> (+0.31%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #2150: Do not pretend to cache rust build artifacts, speed up CI by ~20%
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2150:
URL: https://github.com/apache/arrow-rs/pull/2150#issuecomment-1193189288
cc @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2150: Do not pretend to cache rust build artifacts, speed up CI by ~20%
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2150:
URL: https://github.com/apache/arrow-rs/pull/2150#issuecomment-1193195501
Benchmark runs are scheduled for baseline = 19a71899d828f1c6204c97542645fd801a848ceb and contender = 7560fbd550fc08c53f8db8439b9b9ea606dc81f8. 7560fbd550fc08c53f8db8439b9b9ea606dc81f8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bc5931b90f144f80a85bb313c7932e2f...be833868df7f423a981b01f07e2279d2/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0f888affd4e64cf584d6212ed0c96d34...8e558ef76256499ab28f578596163cf9/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4023c1200d124ddcb35fc8a3c3276456...e38f6e55822d44548bd15c066ca49eb9/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4869bc9b3ee640aea07229fb8e5297dc...59dbb0a92a334b54940fe8ce2da69e67/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org