You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/01/19 04:22:20 UTC
[GitHub] [incubator-doris] lingbin commented on a change in pull request
#2792: Reformat BE code 1/7
lingbin commented on a change in pull request #2792: Reformat BE code 1/7
URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368264710
##########
File path: be/src/agent/agent_server.cpp
##########
@@ -53,12 +55,8 @@ using std::vector;
namespace doris {
-AgentServer::AgentServer(ExecEnv* exec_env,
- const TMasterInfo& master_info) :
- _exec_env(exec_env),
- _master_info(master_info),
- _topic_subscriber(new TopicSubscriber()) {
-
+AgentServer::AgentServer(ExecEnv* exec_env, const TMasterInfo& master_info)
+ : _exec_env(exec_env), _master_info(master_info), _topic_subscriber(new TopicSubscriber()) {
Review comment:
This modification conflicts with Baidu's internal code style specifications, which requires the colon(':') to be placed after the previous line. Because all the code of the current Doris is like this, so I suggest to modify the format file to avoid modifying all the files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org