[GitHub] john-bodley commented on a change in pull request #5703: [sqlparse] fix sqlparse bug

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #5703: [sqlparse] fix sqlparse bug
URL: https://github.com/apache/incubator-superset/pull/5703#discussion_r212140588
 
 

 ##########
 File path: superset/sql_parse.py
 ##########
 @@ -128,7 +129,8 @@ def __extract_from_token(self, token):
                 continue
 
             if item.ttype in Keyword:
-                if self.__is_result_operation(item.value):
+                if (self.__is_result_operation(item.value) or
+                        item.value.upper() == ON_KEYWORD):
 
 Review comment:
   It seems like line #134 is (and was) obsolete and that this check simply ensures one doesn't break.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org