[GitHub] incubator-eagle issue #412: This is for code review only: EAGLE-432 Applicat...

[DadanielZ <gi...@git.apache.org>]

Github user DadanielZ commented on the issue:

    https://github.com/apache/incubator-eagle/pull/412
  
    hi Team, I am working on application status part and here is an initial code review, just want make sure all corner cases are covered and the work flow is correct.
    
    My idea is:
    User can trigger following status for an applicaitonEntity: 
    "INSTALLED"(once an application entity is created, it is always set as "INSTALLED", so there will be no "INSTALLING" status), "STARTING",  "STOPPING", "UNINSTALLING", "UNINSTALLED"
    
    Other status including "RUNNING" and "STOPPED" should only be determined by "background task", which combine the current (stale) status in applicationEntity and status in storm restapi call response.
    
    current question is :
    1. if users triggers an "ING" status, but this topology never get a chance to be updated in storm, what should we do?
    -  for "starting", retry for a certain times automatically or wait for a certain time then set status as "FAILED" or reset it to previous status?
    -  for "stopping", retry or wait or reset it to previous status?
    
    2.  "stop" function defined in ApplicaitonContext is in fact equals to "kill" a storm topology, which is confusing, as storm support "inactive" status for a "stopped" topology. May be we should add a similar function in eagle too?
    
    Any advice will be appreciated.
    
    Thanks and Regards,
    Da


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---